WebPushChannel::handleReports() - Code Metrics - Inspection of "Microsoft Edge is supported now" - laravel-notification-channels/webpush - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#124)

unknown

created 2020-05-19 08:10 UTC

WebPushChannel::handleReports() A

↳ Parent: WebPushChannel

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	0
cts	5
cp	0
rs	9.9666
c	0
b	0
f	0
cc	4
nc	3
nop	3
crap	20

<?php

namespace NotificationChannels\WebPush;

use Illuminate\Notifications\Notification;
use Minishlink\WebPush\Subscription;
use Minishlink\WebPush\WebPush;

class WebPushChannel
{
    /**
     * @var \Minishlink\WebPush\WebPush
     */
    protected $webPush;

    /**
     * @var \NotificationChannels\WebPush\ReportHandlerInterface
     */
    protected $reportHandler;

    /**
     * @param  \Minishlink\WebPush\WebPush $webPush
     * @param  \NotificationChannels\WebPush\ReportHandlerInterface $webPush
     * @return void

     */
    public function __construct(WebPush $webPush, ReportHandlerInterface $reportHandler)
    {
        $this->webPush = $webPush;
        $this->reportHandler = $reportHandler;
    }

    /**
     * Send the given notification.
     *
     * @param  mixed $notifiable
     * @param  \Illuminate\Notifications\Notification $notification
     * @return void
     */
    public function send($notifiable, Notification $notification)
    {
        /** @var \Illuminate\Database\Eloquent\Collection $subscriptions */
        $subscriptions = $notifiable->routeNotificationFor('WebPush', $notification);

        if (empty($subscriptions)) {
            return;
        }

        /** @var \NotificationChannels\WebPush\WebPushMessage $message */
        $message = $notification->toWebPush($notifiable, $notification);

        $payload = json_encode($message->toArray());
        $options = $message->getOptions();

        /** @var \NotificationChannels\WebPush\PushSubscription $subscription */
        foreach ($subscriptions as $subscription) {
            $this->webPush->sendNotification(new Subscription(
                $subscription->endpoint,
                $subscription->public_key,
                $subscription->auth_token,
                $subscription->content_encoding
            ), $payload, false, $options);
        }

        $reports = $this->webPush->flush();

        $this->handleReports($reports, $subscriptions, $message);
    }

    /**
     * Handle the reports.
     *
     * @param  \Generator $reports
     * @param  \Illuminate\Database\Eloquent\Collection $subscriptions
     * @param  \NotificationChannels\WebPush\WebPushMessage $message
     * @return void
     */
    protected function handleReports($reports, $subscriptions, $message)
    {
        /** @var \Minishlink\WebPush\MessageSentReport $report */
        foreach ($reports as $report) {
            if ($report && $subscription = $this->findSubscription($subscriptions, $report)) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
                $this->reportHandler->handleReport($report, $subscription, $message);
            }
        }
    }

    /**
     * @param \Illuminate\Database\Eloquent\Collection $subscriptions
     * @param \Minishlink\WebPush\MessageSentReport $report
     * @return void
     */
    protected function findSubscription($subscriptions, $report)
    {
        foreach ($subscriptions as $subscription) {
            if ($subscription->endpoint === $report->getEndpoint()) {
                return $subscription;
            }
        }
    }
}


1		<?php
2
3		namespace NotificationChannels\WebPush;
4
5		use Illuminate\Notifications\Notification;
6		use Minishlink\WebPush\Subscription;
7		use Minishlink\WebPush\WebPush;
8
9		class WebPushChannel
10		{
11		/**
12		* @var \Minishlink\WebPush\WebPush
13		*/
14		protected $webPush;
15
16		/**
17		* @var \NotificationChannels\WebPush\ReportHandlerInterface
18		*/
19		protected $reportHandler;
20
21		/**
22		* @param \Minishlink\WebPush\WebPush $webPush
23		* @param \NotificationChannels\WebPush\ReportHandlerInterface $webPush
24		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2019-07-27 15:37 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
25		*/
26	2	public function __construct(WebPush $webPush, ReportHandlerInterface $reportHandler)
27		{
28	2	$this->webPush = $webPush;
29	2	$this->reportHandler = $reportHandler;
30	2	}
31
32		/**
33		* Send the given notification.
34		*
35		* @param mixed $notifiable
36		* @param \Illuminate\Notifications\Notification $notification
37		* @return void
38		*/
39		public function send($notifiable, Notification $notification)
40		{
41		/** @var \Illuminate\Database\Eloquent\Collection $subscriptions */
42		$subscriptions = $notifiable->routeNotificationFor('WebPush', $notification);
43
44		if (empty($subscriptions)) {
45		return;
46		}
47
48		/** @var \NotificationChannels\WebPush\WebPushMessage $message */
49		$message = $notification->toWebPush($notifiable, $notification);
		0 ignored issues – show Bug introduced 2019-06-19 20:05 UTC by Report Bug Copy Issue Report The method `toWebPush()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
50		$payload = json_encode($message->toArray());
51		$options = $message->getOptions();
52
53		/** @var \NotificationChannels\WebPush\PushSubscription $subscription */
54		foreach ($subscriptions as $subscription) {
55		$this->webPush->sendNotification(new Subscription(
56		$subscription->endpoint,
57		$subscription->public_key,
58		$subscription->auth_token,
59		$subscription->content_encoding
60		), $payload, false, $options);
61		}
62
63		$reports = $this->webPush->flush();
64
65		$this->handleReports($reports, $subscriptions, $message);
66		}
67
68		/**
69		* Handle the reports.
70		*
71		* @param \Generator $reports
72		* @param \Illuminate\Database\Eloquent\Collection $subscriptions
73		* @param \NotificationChannels\WebPush\WebPushMessage $message
74		* @return void
75		*/
76		protected function handleReports($reports, $subscriptions, $message)
77		{
78		/** @var \Minishlink\WebPush\MessageSentReport $report */
79		foreach ($reports as $report) {
80		if ($report && $subscription = $this->findSubscription($subscriptions, $report)) {
		0 ignored issues – show Bug introduced 2019-07-27 15:37 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$subscription` is correct as `$this->findSubscription($subscriptions, $report)` (which targets `NotificationChannels\Web...nel::findSubscription()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
81		$this->reportHandler->handleReport($report, $subscription, $message);
82		}
83		}
84		}
85
86		/**
87		* @param \Illuminate\Database\Eloquent\Collection $subscriptions
88		* @param \Minishlink\WebPush\MessageSentReport $report
89		* @return void
90		*/
91		protected function findSubscription($subscriptions, $report)
92		{
93		foreach ($subscriptions as $subscription) {
94		if ($subscription->endpoint === $report->getEndpoint()) {
95		return $subscription;
96		}
97		}
98		}
99		}
100

laravel-notification-channels / webpush

GitHub Access Token became invalid

Pull Request — master (#124)

WebPushChannel::handleReports() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like