NotificationChannels\Webhook\WebhookChannel

Complexity

Total Complexity

6

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

92.31%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	send()	0	6	2
A	sendWebhookNotification()	0	15	2
A	getUrlsForNotifiable()	0	4	1

<?php

namespace NotificationChannels\Webhook;

use GuzzleHttp\Exception\RequestException;
use GuzzleHttp\ClientInterface;

use Illuminate\Support\Arr;
use Illuminate\Notifications\Notification;

use NotificationChannels\Webhook\Exceptions\CouldNotSendNotification;

class WebhookChannel
{
    /**
     * @var GuzzleHttp\ClientInterface
     */
    protected $client;

    /**
     * @param GuzzleHttp\ClientInterface
     */
    public function __construct(ClientInterface $client)
    {
        $this->client = $client;

It seems like $client of type object<GuzzleHttp\ClientInterface> is incompatible with the declared type object<NotificationChannels\Webhook\GuzzleHttp\ClientInterface> of property $client.

    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     * @return void
     *
     * @throws \NotificationChannels\Webhook\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        foreach ($this->getUrlsForNotifiable($notifiable) as $url) {
            $this->sendWebhookNotification($notifiable, $notification, $url);
        }
    }

    /**
     * Send the notification to a single webhook
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     * @return void
     *
     * @throws \NotificationChannels\Webhook\Exceptions\CouldNotSendNotification
     */
    protected function sendWebhookNotification($notifiable, Notification $notification, string $url)
    {
        $webhookData = $notification->toWebhook($notifiable)->toArray();

The method toWebhook() does not seem to exist on object<Illuminate\Notifications\Notification>.

        [ 'data' => $data, 'headers' => $headers ] = $webhookData;

The variable $data does not exist. Did you forget to declare it?

The variable $headers does not exist. Did you forget to declare it?

        try {
            $response = $this->client->post($url, [

$response is not used, you could remove the assignment.

                'body'      => json_encode($data),
                'headers'   => $headers 
            ]);
        } catch (RequestException $exception) {
            throw CouldNotSendNotification::serviceRespondedWithAnError($exception->getResponse());

It seems like $exception->getResponse() can be null; however, serviceRespondedWithAnError() does not accept null, maybe add an additional type check?

        }
    }

    /**
     * @param mixed $notifiable
     */
    protected function getUrlsForNotifiable($notifiable)
    {
        return Arr::wrap($notifiable->routeNotificationFor('Webhook'));
    }
}