TwilioSmsMessage::provideFeedback() - Code Metrics - Inspection of "Add Twilio messages optional parameters" - laravel-notification-channels/twilio - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4c36ba...7392fc )

by Gregorio

created 2018-03-17 11:48 UTC

TwilioSmsMessage::provideFeedback() A

↳ Parent: TwilioSmsMessage

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	0
cts	5
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1
crap	2

<?php

namespace NotificationChannels\Twilio;

class TwilioSmsMessage extends TwilioMessage
{
    /**
     * @var null|string
     */
    public $alphaNumSender = null;

    /**
     * @var null|string
     */
    public $applicationSid = null;

    /**
     * @var null|float
     */
    public $maxPrice = null;

    /**
     * @var null|boolean
     */
    public $provideFeedback = null;

    /**
     * @var null|integer
     */
    public $validityPeriod = null;

    /**
     * Get the from address of this message.
     *
     * @return null|string
     */
    public function getFrom()
    {
        if ($this->from) {
            return $this->from;
        }

        if ($this->alphaNumSender && strlen($this->alphaNumSender) > 0) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this->alphaNumSender;
        }
    }

    /**
     * Set the alphanumeric sender.
     *
     * @param string $sender
     * @return $this
     */
    public function sender($sender)
    {
        $this->alphaNumSender = $sender;

        return $this;
    }

    /**
     * Set application SID for the message status callback.
     *
     * @param string $applicationSid
     * @return $this
     */
    public function applicationSid($applicationSid)
    {
        $this->applicationSid = $applicationSid;

        return $this;
    }

    /**
     * Set the max price (in USD dollars).
     *
     * @param float $maxPrice
     * @return $this
     */
    public function maxPrice($maxPrice)
    {
        $this->maxPrice = $maxPrice;

        return $this;
    }

    /**
     * Set the provide feedback option.
     *
     * @param boolean $provideFeedback
     * @return $this
     */
    public function provideFeedback($provideFeedback)
    {
        $this->provideFeedback = $provideFeedback;

        return $this;
    }

    /**
     * Set the validity period (in seconds).
     *
     * @param integer $validityPeriod
     * @return $this
     */
    public function validityPeriod($validityPeriod)
    {
        $this->validityPeriod = $validityPeriod;

        return $this;
    }
}


1			<?php
2
3			namespace NotificationChannels\Twilio;
4
5			class TwilioSmsMessage extends TwilioMessage
6			{
7			/**
8			* @var null\|string
9			*/
10			public $alphaNumSender = null;
11
12			/**
13			* @var null\|string
14			*/
15			public $applicationSid = null;
16
17			/**
18			* @var null\|float
19			*/
20			public $maxPrice = null;
21
22			/**
23			* @var null\|boolean
24			*/
25			public $provideFeedback = null;
26
27			/**
28			* @var null\|integer
29			*/
30			public $validityPeriod = null;
31
32			/**
33			* Get the from address of this message.
34			*
35			* @return null\|string
36			*/
37			public function getFrom()
38			{
39			if ($this->from) {
40			return $this->from;
41			}
42
43			if ($this->alphaNumSender && strlen($this->alphaNumSender) > 0) {
			0 ignored issues – show Bug Best Practice introduced 2016-09-29 22:34 UTC by Report Bug Copy Issue Report The expression `$this->alphaNumSender` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
44			return $this->alphaNumSender;
45			}
46			}
47
48			/**
49			* Set the alphanumeric sender.
50			*
51			* @param string $sender
52			* @return $this
53			*/
54			public function sender($sender)
55			{
56			$this->alphaNumSender = $sender;
57
58			return $this;
59			}
60
61			/**
62			* Set application SID for the message status callback.
63			*
64			* @param string $applicationSid
65			* @return $this
66			*/
67			public function applicationSid($applicationSid)
68			{
69			$this->applicationSid = $applicationSid;
70
71			return $this;
72			}
73
74			/**
75			* Set the max price (in USD dollars).
76			*
77			* @param float $maxPrice
78			* @return $this
79			*/
80			public function maxPrice($maxPrice)
81			{
82			$this->maxPrice = $maxPrice;
83
84			return $this;
85			}
86
87			/**
88			* Set the provide feedback option.
89			*
90			* @param boolean $provideFeedback
91			* @return $this
92			*/
93			public function provideFeedback($provideFeedback)
94			{
95			$this->provideFeedback = $provideFeedback;
96
97			return $this;
98			}
99
100			/**
101			* Set the validity period (in seconds).
102			*
103			* @param integer $validityPeriod
104			* @return $this
105			*/
106			public function validityPeriod($validityPeriod)
107			{
108			$this->validityPeriod = $validityPeriod;
109
110			return $this;
111			}
112			}
113

laravel-notification-channels / twilio

GitHub Access Token became invalid

Push — master ( 4c36ba...7392fc )

TwilioSmsMessage::provideFeedback() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like