NotificationChannels\Twilio\Twilio

Complexity

Total Complexity

23

Size/Duplication

Total Lines	203
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	11

Test Coverage

Coverage

98.44%

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	sendMessage()	0	20	6
B	sendSmsMessage()	0	28	3
A	notifyMessage()	0	13	1
A	makeCall()	0	21	1
A	getFrom()	0	8	3
A	getAlphanumericSender()	0	6	2
A	getServiceSid()	0	10	3
A	fillOptionalParams()	0	8	3

<?php

namespace NotificationChannels\Twilio;

use Twilio\Rest\Client as TwilioService;
use NotificationChannels\Twilio\Exceptions\CouldNotSendNotification;

class Twilio
{
    /**
     * @var TwilioService
     */
    protected $twilioService;

    /**
     * @var TwilioConfig
     */
    private $config;

    /**
     * Twilio constructor.
     *
     * @param  TwilioService $twilioService
     * @param TwilioConfig $config
     */
    public function __construct(TwilioService $twilioService, TwilioConfig $config)
    {
        $this->twilioService = $twilioService;
        $this->config = $config;
    }

    /**
     * Send a TwilioMessage to the a phone number.
     *
     * @param  TwilioMessage $message
     * @param  string $to
     * @param bool $useAlphanumericSender
     * @return mixed
     * @throws CouldNotSendNotification
     */
    public function sendMessage(TwilioMessage $message, $to, $useAlphanumericSender = false)
    {
        if ($message instanceof TwilioSmsMessage) {
            if ($useAlphanumericSender && $sender = $this->getAlphanumericSender()) {
                $message->from($sender);
            }

            return $this->sendSmsMessage($message, $to);
        }
       
        if ($message instanceof TwilioNotifyMessage) {
            return $this->notifyMessage($message, $to);
        }

        if ($message instanceof TwilioCallMessage) {
            return $this->makeCall($message, $to);
        }
        
        throw CouldNotSendNotification::invalidMessageObject($message);
    }

    /**
     * Send an sms message using the Twilio Service.
     *
     * @param TwilioSmsMessage $message
     * @param string $to
     * @return \Twilio\Rest\Api\V2010\Account\MessageInstance
     * @throws CouldNotSendNotification
     */
    protected function sendSmsMessage(TwilioSmsMessage $message, $to)
    {
        $params = [
            'from' => $this->getFrom($message),
            'body' => trim($message->content),
        ];

        if ($service_sid = $this->config->getServiceSid()) {
            $params['messagingServiceSid'] = $service_sid;
        }

        $this->fillOptionalParams($params, $message, [
            'statusCallback',
            'statusCallbackMethod',
            'applicationSid',
            'maxPrice',
            'provideFeedback',
            'validityPeriod',
        ]);

        if ($message instanceof TwilioMmsMessage) {
            $this->fillOptionalParams($params, $message, [
                'mediaUrl',
            ]);
        }

        return $this->twilioService->messages->create($to, $params);
    }

    /**
     * Send an notify message uing the Twilio service
     *
     * @param TwilioNotifyMessage $message
     * @param string              $to
     * @return \Twilio
     */
    protected function notifyMessage(TwilioNotifyMessage $message, $to)
    {
        $params = [
            "toBinding" => '{"binding_type":"sms", "address":"'. $to .'"}',
            'body' => trim($message->content)
        ];

        $service_sid = $this->getServiceSid($message);

        return $this->twilioService
                ->notify->services($service_sid)
                ->notifications->create($params);
    }

    /**
     * Make a call using the Twilio Service.
     *
     * @param TwilioCallMessage $message
     * @param string $to
     * @return \Twilio\Rest\Api\V2010\Account\CallInstance
     * @throws CouldNotSendNotification
     */
    protected function makeCall(TwilioCallMessage $message, $to)
    {
        $params = [
            'url' => trim($message->content),
        ];

        $this->fillOptionalParams($params, $message, [
            'statusCallback',
            'statusCallbackMethod',
            'method',
            'status',
            'fallbackUrl',
            'fallbackMethod',
        ]);

        return $this->twilioService->calls->create(
            $to,
            $this->getFrom($message),
            $params
        );
    }

    /**
     * Get the from address from message, or config.
     *
     * @param TwilioMessage $message
     * @return string
     * @throws CouldNotSendNotification
     */
    protected function getFrom(TwilioMessage $message)
    {
        if (! $from = $message->getFrom() ?: $this->config->getFrom()) {
            throw CouldNotSendNotification::missingFrom();
        }

        return $from;
    }

    /**
     * Get the alphanumeric sender from config, if one exists.
     *
     * @return string|null
     */
    protected function getAlphanumericSender()
    {
        if ($sender = $this->config->getAlphanumericSender()) {
            return $sender;
        }
    }

    /**
     * get service sid
     *
     * @param TwilioMessage $message
     * @return string
     * @throws CouldNotSendNotification
     */
    protected function getServiceSid(TwilioMessage $message)
    {
        if (! $service_sid = $message->getServiceSid()) {

It seems like you code against a specific sub-type and not the parent class NotificationChannels\Twilio\TwilioMessage as the method getServiceSid() does only exist in the following sub-classes of NotificationChannels\Twilio\TwilioMessage: NotificationChannels\Twilio\TwilioNotifyMessage. Maybe you want to instanceof check for one of these explicitly?

            if (! $service_sid = $this->config->getServiceSid()) {
                throw CouldNotSendNotification::missingServiceSid();
            }
        }

        return $service_sid;
    }

    /**
     * @param array $params
     * @param TwilioMessage $message
     * @param array $optionalParams
     * @return mixed
     */
    protected function fillOptionalParams(&$params, $message, $optionalParams)
    {
        foreach ($optionalParams as $optionalParam) {
            if ($message->$optionalParam) {
                $params[$optionalParam] = $message->$optionalParam;
            }
        }
    }
}