TwilioSmsMessage::getFrom() - Code Metrics - Inspection of "Merge pull request #55 from laravel-notification-c..." - laravel-notification-channels/twilio - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 987681...4554fe )

by Gregorio

created 2019-03-04 10:59 UTC

TwilioSmsMessage::getFrom() A

↳ Parent: TwilioSmsMessage

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	0
cts	9
cp	0
rs	9.9332
c	0
b	0
f	0
cc	4
nc	3
nop	0
crap	20

<?php

namespace NotificationChannels\Twilio;

class TwilioSmsMessage extends TwilioMessage
{
    /**
     * @var null|string
     */
    public $alphaNumSender = null;

    /**
     * @var null|string
     */
    public $messagingServiceSid = null;

    /**
     * @var null|string
     */
    public $applicationSid = null;

    /**
     * @var null|float
     */
    public $maxPrice = null;

    /**
     * @var null|bool
     */
    public $provideFeedback = null;

    /**
     * @var null|int
     */
    public $validityPeriod = null;

    /**
     * Get the from address of this message.
     *
     * @return null|string
     */
    public function getFrom()
    {
        if ($this->from) {
            return $this->from;
        }

        if ($this->alphaNumSender && strlen($this->alphaNumSender) > 0) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this->alphaNumSender;
        }
    }

    /**
     * Set the messaging service SID.
     *
     * @param  string $messagingServiceSid
     * @return $this
     */
    public function messagingServiceSid($messagingServiceSid)
    {
        $this->messagingServiceSid = $messagingServiceSid;

        return $this;
    }

    /**
     * Get the messaging service SID of this message.
     *
     * @return null|string
     */
    public function getMessagingServiceSid()
    {
        return $this->messagingServiceSid;
    }

    /**
     * Set the alphanumeric sender.
     *
     * @param string $sender
     * @return $this
     */
    public function sender($sender)
    {
        $this->alphaNumSender = $sender;

        return $this;
    }

    /**
     * Set application SID for the message status callback.
     *
     * @param string $applicationSid
     * @return $this
     */
    public function applicationSid($applicationSid)
    {
        $this->applicationSid = $applicationSid;

        return $this;
    }

    /**
     * Set the max price (in USD dollars).
     *
     * @param float $maxPrice
     * @return $this
     */
    public function maxPrice($maxPrice)
    {
        $this->maxPrice = $maxPrice;

        return $this;
    }

    /**
     * Set the provide feedback option.
     *
     * @param bool $provideFeedback
     * @return $this
     */
    public function provideFeedback($provideFeedback)
    {
        $this->provideFeedback = $provideFeedback;

        return $this;
    }

    /**
     * Set the validity period (in seconds).
     *
     * @param int $validityPeriod
     * @return $this
     */
    public function validityPeriod($validityPeriod)
    {
        $this->validityPeriod = $validityPeriod;

        return $this;
    }
}


1			<?php
2
3			namespace NotificationChannels\Twilio;
4
5			class TwilioSmsMessage extends TwilioMessage
6			{
7			/**
8			* @var null\|string
9			*/
10			public $alphaNumSender = null;
11
12			/**
13			* @var null\|string
14			*/
15			public $messagingServiceSid = null;
16
17			/**
18			* @var null\|string
19			*/
20			public $applicationSid = null;
21
22			/**
23			* @var null\|float
24			*/
25			public $maxPrice = null;
26
27			/**
28			* @var null\|bool
29			*/
30			public $provideFeedback = null;
31
32			/**
33			* @var null\|int
34			*/
35			public $validityPeriod = null;
36
37			/**
38			* Get the from address of this message.
39			*
40			* @return null\|string
41			*/
42			public function getFrom()
43			{
44			if ($this->from) {
45			return $this->from;
46			}
47
48			if ($this->alphaNumSender && strlen($this->alphaNumSender) > 0) {
			0 ignored issues – show Bug Best Practice introduced 2016-09-29 22:34 UTC by Report Bug Copy Issue Report The expression `$this->alphaNumSender` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
49			return $this->alphaNumSender;
50			}
51			}
52
53			/**
54			* Set the messaging service SID.
55			*
56			* @param string $messagingServiceSid
57			* @return $this
58			*/
59			public function messagingServiceSid($messagingServiceSid)
60			{
61			$this->messagingServiceSid = $messagingServiceSid;
62
63			return $this;
64			}
65
66			/**
67			* Get the messaging service SID of this message.
68			*
69			* @return null\|string
70			*/
71			public function getMessagingServiceSid()
72			{
73			return $this->messagingServiceSid;
74			}
75
76			/**
77			* Set the alphanumeric sender.
78			*
79			* @param string $sender
80			* @return $this
81			*/
82			public function sender($sender)
83			{
84			$this->alphaNumSender = $sender;
85
86			return $this;
87			}
88
89			/**
90			* Set application SID for the message status callback.
91			*
92			* @param string $applicationSid
93			* @return $this
94			*/
95			public function applicationSid($applicationSid)
96			{
97			$this->applicationSid = $applicationSid;
98
99			return $this;
100			}
101
102			/**
103			* Set the max price (in USD dollars).
104			*
105			* @param float $maxPrice
106			* @return $this
107			*/
108			public function maxPrice($maxPrice)
109			{
110			$this->maxPrice = $maxPrice;
111
112			return $this;
113			}
114
115			/**
116			* Set the provide feedback option.
117			*
118			* @param bool $provideFeedback
119			* @return $this
120			*/
121			public function provideFeedback($provideFeedback)
122			{
123			$this->provideFeedback = $provideFeedback;
124
125			return $this;
126			}
127
128			/**
129			* Set the validity period (in seconds).
130			*
131			* @param int $validityPeriod
132			* @return $this
133			*/
134			public function validityPeriod($validityPeriod)
135			{
136			$this->validityPeriod = $validityPeriod;
137
138			return $this;
139			}
140			}
141

laravel-notification-channels / twilio

GitHub Access Token became invalid

Push — master ( 987681...4554fe )

TwilioSmsMessage::getFrom() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like