TrelloChannel::send() - Code Metrics - Inspection of "add method for insert labels to card" - laravel-notification-channels/trello - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

unknown

created 2018-05-28 03:55 UTC

TrelloChannel::send() B

↳ Parent: TrelloChannel

Complexity

Conditions	4
Paths	4

Size

Total Lines	22
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	22
ccs	0
cts	17
cp	0
rs	8.9197
c	1
b	0
f	0
cc	4
eloc	11
nc	4
nop	2
crap	20

<?php

namespace NotificationChannels\Trello;

use GuzzleHttp\Client;
use Illuminate\Support\Arr;
use Illuminate\Notifications\Notification;
use NotificationChannels\Trello\Exceptions\InvalidConfiguration;
use NotificationChannels\Trello\Exceptions\CouldNotSendNotification;

class TrelloChannel
{
    const API_ENDPOINT = 'https://api.trello.com/1/cards/';

    /** @var Client */
    protected $client;

    /** @param Client $client */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @throws \NotificationChannels\Trello\Exceptions\InvalidConfiguration
     * @throws \NotificationChannels\Trello\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        if (! $routing = collect($notifiable->routeNotificationFor('Trello'))) {
            return;
        }

        $key = config('services.trello.key');

        if (is_null($key)) {
            throw InvalidConfiguration::configurationNotSet();
        }

        $trelloParameters = $notification->toTrello($notifiable)->toArray();


        $response = $this->client->post(self::API_ENDPOINT.'?key='.$key.'&token='.$routing->get('token'), [
            'form_params' => Arr::set($trelloParameters, 'idList', $routing->get('idList')),
        ]);

        if ($response->getStatusCode() !== 200) {
            throw CouldNotSendNotification::serviceRespondedWithAnError($response);
        }
    }
}


1			<?php
2
3			namespace NotificationChannels\Trello;
4
5			use GuzzleHttp\Client;
6			use Illuminate\Support\Arr;
7			use Illuminate\Notifications\Notification;
8			use NotificationChannels\Trello\Exceptions\InvalidConfiguration;
9			use NotificationChannels\Trello\Exceptions\CouldNotSendNotification;
10
11			class TrelloChannel
12			{
13			const API_ENDPOINT = 'https://api.trello.com/1/cards/';
14
15			/** @var Client */
16			protected $client;
17
18			/** @param Client $client */
19			public function __construct(Client $client)
20			{
21			$this->client = $client;
22			}
23
24			/**
25			* Send the given notification.
26			*
27			* @param mixed $notifiable
28			* @param \Illuminate\Notifications\Notification $notification
29			*
30			* @throws \NotificationChannels\Trello\Exceptions\InvalidConfiguration
31			* @throws \NotificationChannels\Trello\Exceptions\CouldNotSendNotification
32			*/
33			public function send($notifiable, Notification $notification)
34			{
35			if (! $routing = collect($notifiable->routeNotificationFor('Trello'))) {
36			return;
37			}
38
39			$key = config('services.trello.key');
40
41			if (is_null($key)) {
42			throw InvalidConfiguration::configurationNotSet();
43			}
44
45			$trelloParameters = $notification->toTrello($notifiable)->toArray();
			0 ignored issues – show Bug introduced 2016-08-14 18:38 UTC by Report Bug Copy Issue Report The method `toTrello()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
46
47			$response = $this->client->post(self::API_ENDPOINT.'?key='.$key.'&token='.$routing->get('token'), [
48			'form_params' => Arr::set($trelloParameters, 'idList', $routing->get('idList')),
49			]);
50
51			if ($response->getStatusCode() !== 200) {
52			throw CouldNotSendNotification::serviceRespondedWithAnError($response);
53			}
54			}
55			}
56

laravel-notification-channels / trello

Pull Request — master (#10)

TrelloChannel::send() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like