NotificationChannels\Smspoh\SmspohChannel

Complexity

Total Complexity

7

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	send()	0	21	6

<?php

namespace NotificationChannels\Smspoh;

use Illuminate\Notifications\Notification;
use NotificationChannels\Smspoh\Exceptions\CouldNotSendNotification;

class SmspohChannel
{
    /**
     * The Smspoh client instance.
     *
     * @var SmspohApi
     */
    protected $smspoh;

    /**
     * The phone number notifications should be sent from.
     *
     * @var string
     */
    protected $sender;

    /**
     * @var int
     * The message body content count should be no longer than 6 message parts(918).
     */
    protected $character_limit_count = 918;

    public function __construct(SmspohApi $smspoh, $sender)
    {
        $this->smspoh = $smspoh;
        $this->sender = $sender;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param Notification $notification
     *
     * @return mixed|\Psr\Http\Message\ResponseInterface|void
     * @throws CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        if (! $to = $notifiable->routeNotificationFor('smspoh', $notification)) {
            return;
        }

        $message = $notification->toSmspoh($notifiable);

The method toSmspoh() does not exist on Illuminate\Notifications\Notification. It seems like you code against a sub-type of said class. However, the method does not exist in Illuminate\Auth\Notifications\ResetPassword or Illuminate\Auth\Notifications\VerifyEmail. Are you sure you never get one of those?

        if (is_string($message)) {
            $message = new SmspohMessage($message);
        }

        if (mb_strlen($message->content) > $this->character_limit_count) {
            throw CouldNotSendNotification::contentLengthLimitExceeded($this->character_limit_count);
        }

        return $this->smspoh->send([
            'sender' => $message->sender ?: $this->sender,
            'to' => $to,
            'message' => trim($message->content),
            'test' => $message->test ?: false,
        ]);
    }
}