SmscRuApi::__construct() - Code Metrics - Inspection of "Updated to support Laravel 5.6 - fix issue #21 (#2..." - laravel-notification-channels/smsc-ru - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 53051f...8c4fc0 )

by Jhao

created 2018-02-10 16:45 UTC

SmscRuApi::__construct() A

↳ Parent: SmscRuApi

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
ccs	0
cts	10
cp	0
rs	9.4285
cc	1
eloc	7
nc	1
nop	3
crap	2

<?php

namespace NotificationChannels\SmscRu;

use DomainException;
use GuzzleHttp\Client as HttpClient;
use NotificationChannels\SmscRu\Exceptions\CouldNotSendNotification;

class SmscRuApi
{
    const FORMAT_JSON = 3;

    /** @var string */
    protected $apiUrl = 'https://smsc.ru/sys/send.php';

    /** @var HttpClient */
    protected $httpClient;

    /** @var string */
    protected $login;

    /** @var string */
    protected $secret;

    /** @var string */
    protected $sender;

    public function __construct($login, $secret, $sender)
    {
        $this->login = $login;
        $this->secret = $secret;
        $this->sender = $sender;

        $this->httpClient = new HttpClient([
            'timeout' => 5,
            'connect_timeout' => 5,
        ]);
    }

    /**
     * @param  array  $params
     *
     * @return array
     *
     * @throws CouldNotSendNotification
     */
    public function send($params)
    {
        $base = [
            'charset' => 'utf-8',
            'login'   => $this->login,
            'psw'     => $this->secret,
            'sender'  => $this->sender,
            'fmt'     => self::FORMAT_JSON,
        ];

        $params = array_merge($base, $params);

        try {
            $response = $this->httpClient->post($this->apiUrl, ['form_params' => $params]);

            $response = json_decode((string) $response->getBody(), true);

            if (isset($response['error'])) {
                throw new DomainException($response['error'], $response['error_code']);
            }

            return $response;
        } catch (DomainException $exception) {
            throw CouldNotSendNotification::smscRespondedWithAnError($exception);
        } catch (\Exception $exception) {
            throw CouldNotSendNotification::couldNotCommunicateWithSmsc($exception);
        }
    }
}


1			<?php
2
3			namespace NotificationChannels\SmscRu;
4
5			use DomainException;
6			use GuzzleHttp\Client as HttpClient;
7			use NotificationChannels\SmscRu\Exceptions\CouldNotSendNotification;
8
9			class SmscRuApi
10			{
11			const FORMAT_JSON = 3;
12
13			/** @var string */
14			protected $apiUrl = 'https://smsc.ru/sys/send.php';
15
16			/** @var HttpClient */
17			protected $httpClient;
18
19			/** @var string */
20			protected $login;
21
22			/** @var string */
23			protected $secret;
24
25			/** @var string */
26			protected $sender;
27
28			public function __construct($login, $secret, $sender)
29			{
30			$this->login = $login;
31			$this->secret = $secret;
32			$this->sender = $sender;
33
34			$this->httpClient = new HttpClient([
35			'timeout' => 5,
36			'connect_timeout' => 5,
37			]);
38			}
39
40			/**
41			* @param array $params
42			*
43			* @return array
44			*
45			* @throws CouldNotSendNotification
46			*/
47			public function send($params)
48			{
49			$base = [
50			'charset' => 'utf-8',
51			'login' => $this->login,
52			'psw' => $this->secret,
53			'sender' => $this->sender,
54			'fmt' => self::FORMAT_JSON,
55			];
56
57			$params = array_merge($base, $params);
58
59			try {
60			$response = $this->httpClient->post($this->apiUrl, ['form_params' => $params]);
61
62			$response = json_decode((string) $response->getBody(), true);
63
64			if (isset($response['error'])) {
65			throw new DomainException($response['error'], $response['error_code']);
66			}
67
68			return $response;
69			} catch (DomainException $exception) {
70			throw CouldNotSendNotification::smscRespondedWithAnError($exception);
71			} catch (\Exception $exception) {
72			throw CouldNotSendNotification::couldNotCommunicateWithSmsc($exception);
73			}
74			}
75			}
76

laravel-notification-channels / smsc-ru

GitHub Access Token became invalid

Push — master ( 53051f...8c4fc0 )

SmscRuApi::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like