SmscRuChannel::sendMessage() - Code Metrics - Inspection of "Fix notification routing method name (#16)" - laravel-notification-channels/smsc-ru - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e92d25...a22394 )

by Jhao

created 2017-07-20 13:23 UTC

SmscRuChannel::sendMessage() A

↳ Parent: SmscRuChannel

Complexity

Conditions	3
Paths	3

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	18
ccs	0
cts	15
cp	0
rs	9.4285
cc	3
eloc	10
nc	3
nop	2
crap	12

<?php

namespace NotificationChannels\SmscRu;

use Illuminate\Notifications\Notification;
use NotificationChannels\SmscRu\Exceptions\CouldNotSendNotification;

class SmscRuChannel
{
    /** @var \NotificationChannels\SmscRu\SmscRuApi */
    protected $smsc;

    public function __construct(SmscRuApi $smsc)
    {
        $this->smsc = $smsc;
    }

    /**
     * Send the given notification.
     *
     * @param  mixed  $notifiable
     * @param  \Illuminate\Notifications\Notification  $notification
     *
     * @throws  \NotificationChannels\SmscRu\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        $to = $notifiable->routeNotificationFor('smscru');

        if (empty($to)) {
            throw CouldNotSendNotification::missingRecipient();
        }

        $message = $notification->toSmscRu($notifiable);


        if (is_string($message)) {
            $message = new SmscRuMessage($message);
        }

        $this->sendMessage($to, $message);
    }

    protected function sendMessage($recipient, SmscRuMessage $message)
    {
        if (mb_strlen($message->content) > 800) {
            throw CouldNotSendNotification::contentLengthLimitExceeded();
        }

        $params = [
            'phones'  => $recipient,
            'mes'     => $message->content,
            'sender'  => $message->from,
        ];

        if ($message->sendAt instanceof \DateTimeInterface) {
            $params['time'] = '0'.$message->sendAt->getTimestamp();
        }

        $this->smsc->send($params);
    }
}


1			<?php
2
3			namespace NotificationChannels\SmscRu;
4
5			use Illuminate\Notifications\Notification;
6			use NotificationChannels\SmscRu\Exceptions\CouldNotSendNotification;
7
8			class SmscRuChannel
9			{
10			/** @var \NotificationChannels\SmscRu\SmscRuApi */
11			protected $smsc;
12
13			public function __construct(SmscRuApi $smsc)
14			{
15			$this->smsc = $smsc;
16			}
17
18			/**
19			* Send the given notification.
20			*
21			* @param mixed $notifiable
22			* @param \Illuminate\Notifications\Notification $notification
23			*
24			* @throws \NotificationChannels\SmscRu\Exceptions\CouldNotSendNotification
25			*/
26			public function send($notifiable, Notification $notification)
27			{
28			$to = $notifiable->routeNotificationFor('smscru');
29
30			if (empty($to)) {
31			throw CouldNotSendNotification::missingRecipient();
32			}
33
34			$message = $notification->toSmscRu($notifiable);
			0 ignored issues – show Bug introduced 2016-08-15 13:55 UTC by Report Bug Copy Issue Report The method `toSmscRu()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
35
36			if (is_string($message)) {
37			$message = new SmscRuMessage($message);
38			}
39
40			$this->sendMessage($to, $message);
41			}
42
43			protected function sendMessage($recipient, SmscRuMessage $message)
44			{
45			if (mb_strlen($message->content) > 800) {
46			throw CouldNotSendNotification::contentLengthLimitExceeded();
47			}
48
49			$params = [
50			'phones' => $recipient,
51			'mes' => $message->content,
52			'sender' => $message->from,
53			];
54
55			if ($message->sendAt instanceof \DateTimeInterface) {
56			$params['time'] = '0'.$message->sendAt->getTimestamp();
57			}
58
59			$this->smsc->send($params);
60			}
61			}
62

laravel-notification-channels / smsc-ru

GitHub Access Token became invalid

Push — master ( e92d25...a22394 )

SmscRuChannel::sendMessage() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like