SmscRuChannel::send() - Code Metrics - Inspection of "Fix typo" - laravel-notification-channels/smsc-ru - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3dd017...b8ade9 )

by Jhao

created 2017-08-30 17:04 UTC

SmscRuChannel::send() A

↳ Parent: SmscRuChannel

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3.072

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	16
ccs	8
cts	10
cp	0.8
rs	9.4285
cc	3
eloc	8
nc	3
nop	2
crap	3.072

<?php

namespace NotificationChannels\SmscRu;

use Illuminate\Notifications\Notification;
use NotificationChannels\SmscRu\Exceptions\CouldNotSendNotification;

class SmscRuChannel
{
    /** @var \NotificationChannels\SmscRu\SmscRuApi */
    protected $smsc;

    public function __construct(SmscRuApi $smsc)
    {
        $this->smsc = $smsc;
    }

    /**
     * Send the given notification.
     *
     * @param  mixed  $notifiable
     * @param  \Illuminate\Notifications\Notification  $notification
     *
     * @throws  \NotificationChannels\SmscRu\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        $to = $notifiable->routeNotificationFor('smscru');

        if (empty($to)) {
            throw CouldNotSendNotification::missingRecipient();
        }

        $message = $notification->toSmscRu($notifiable);


        if (is_string($message)) {
            $message = new SmscRuMessage($message);
        }

        $this->sendMessage($to, $message);
    }

    protected function sendMessage($recipient, SmscRuMessage $message)
    {
        if (mb_strlen($message->content) > 800) {
            throw CouldNotSendNotification::contentLengthLimitExceeded();
        }

        $params = [
            'phones'  => $recipient,
            'mes'     => $message->content,
            'sender'  => $message->from,
        ];

        if ($message->sendAt instanceof \DateTimeInterface) {
            $params['time'] = '0'.$message->sendAt->getTimestamp();
        }

        $this->smsc->send($params);
    }
}


1		<?php
2
3		namespace NotificationChannels\SmscRu;
4
5		use Illuminate\Notifications\Notification;
6		use NotificationChannels\SmscRu\Exceptions\CouldNotSendNotification;
7
8		class SmscRuChannel
9		{
10		/** @var \NotificationChannels\SmscRu\SmscRuApi */
11		protected $smsc;
12
13	3	public function __construct(SmscRuApi $smsc)
14		{
15	3	$this->smsc = $smsc;
16	3	}
17
18		/**
19		* Send the given notification.
20		*
21		* @param mixed $notifiable
22		* @param \Illuminate\Notifications\Notification $notification
23		*
24		* @throws \NotificationChannels\SmscRu\Exceptions\CouldNotSendNotification
25		*/
26	3	public function send($notifiable, Notification $notification)
27		{
28	3	$to = $notifiable->routeNotificationFor('smscru');
29
30	3	if (empty($to)) {
31	1	throw CouldNotSendNotification::missingRecipient();
32		}
33
34	2	$message = $notification->toSmscRu($notifiable);
		0 ignored issues – show Bug introduced 2016-08-15 13:55 UTC by Report Bug Copy Issue Report The method `toSmscRu()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
35
36	2	if (is_string($message)) {
37		$message = new SmscRuMessage($message);
38		}
39
40	2	$this->sendMessage($to, $message);
41	2	}
42
43	2	protected function sendMessage($recipient, SmscRuMessage $message)
44		{
45	2	if (mb_strlen($message->content) > 800) {
46		throw CouldNotSendNotification::contentLengthLimitExceeded();
47		}
48
49		$params = [
50	2	'phones' => $recipient,
51	2	'mes' => $message->content,
52	2	'sender' => $message->from,
53	2	];
54
55	2	if ($message->sendAt instanceof \DateTimeInterface) {
56	1	$params['time'] = '0'.$message->sendAt->getTimestamp();
57	1	}
58
59	2	$this->smsc->send($params);
60	2	}
61		}
62

laravel-notification-channels / smsc-ru

GitHub Access Token became invalid

Push — master ( 3dd017...b8ade9 )

SmscRuChannel::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like