PushoverChannel::send() - Code Metrics - Inspection of "Refactor PushoverChannel" - laravel-notification-channels/pushover - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f96e3c...dc495a )

by Casper

created 2016-08-25 12:11 UTC

PushoverChannel::send() A

↳ Parent: PushoverChannel

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	3

Importance

Changes	6
Bugs	1	Features	0

Metric	Value
c	6
b	1
f	0
dl	0
loc	16
ccs	11
cts	11
cp	1
rs	9.4285
cc	3
eloc	9
nc	3
nop	2
crap	3

<?php

namespace NotificationChannels\Pushover;

use Illuminate\Notifications\Notification;
use Illuminate\Notifications\Events\NotificationFailed;
use Illuminate\Contracts\Events\Dispatcher;
use NotificationChannels\Pushover\Exceptions\ServiceCommunicationError;

class PushoverChannel
{
    /** @var Pushover */
    protected $pushover;

    /**
     * Create a new Pushover channel instance.
     *
     * @param  Pushover $pushover
     */
    public function __construct(Pushover $pushover, Dispatcher $events)
    {
        $this->pushover = $pushover;
        $this->events = $events;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @throws \NotificationChannels\Pushover\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        if (! $pushoverKey = $notifiable->routeNotificationFor('pushover')) {
            return;
        }

        $message = $notification->toPushover($notifiable);


        try {
            $this->pushover->send(array_merge($message->toArray(), [
                'user' => $pushoverKey,
            ]));
        } catch (ServiceCommunicationError $serviceCommunicationError) {
            $this->fireFailedEvent($notifiable, $notification, $serviceCommunicationError->getMessage());
        }
    }

    protected function fireFailedEvent($notifiable, $notification, $message)
    {
        $this->events->fire(
            new NotificationFailed($notifiable, $notification, 'pushover', [$message])
        );
    }
}


1		<?php
2
3		namespace NotificationChannels\Pushover;
4
5		use Illuminate\Notifications\Notification;
6		use Illuminate\Notifications\Events\NotificationFailed;
7		use Illuminate\Contracts\Events\Dispatcher;
8		use NotificationChannels\Pushover\Exceptions\ServiceCommunicationError;
9
10		class PushoverChannel
11		{
12		/** @var Pushover */
13		protected $pushover;
14
15		/**
16		* Create a new Pushover channel instance.
17		*
18		* @param Pushover $pushover
19		*/
20	4	public function __construct(Pushover $pushover, Dispatcher $events)
21		{
22	4	$this->pushover = $pushover;
23	4	$this->events = $events;
		0 ignored issues – show Bug introduced 2016-08-25 12:08 UTC by Report Bug Copy Issue Report The property `events` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24	4	}
25
26		/**
27		* Send the given notification.
28		*
29		* @param mixed $notifiable
30		* @param \Illuminate\Notifications\Notification $notification
31		*
32		* @throws \NotificationChannels\Pushover\Exceptions\CouldNotSendNotification
33		*/
34	4	public function send($notifiable, Notification $notification)
35		{
36	4	if (! $pushoverKey = $notifiable->routeNotificationFor('pushover')) {
37	1	return;
38		}
39
40	3	$message = $notification->toPushover($notifiable);
		0 ignored issues – show Bug introduced 2016-08-12 16:39 UTC by Report Bug Copy Issue Report The method `toPushover()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
41
42		try {
43	3	$this->pushover->send(array_merge($message->toArray(), [
44	3	'user' => $pushoverKey,
45	3	]));
46	3	} catch (ServiceCommunicationError $serviceCommunicationError) {
47	3	$this->fireFailedEvent($notifiable, $notification, $serviceCommunicationError->getMessage());
48	3	}
49	3	}
50	3
51	3	protected function fireFailedEvent($notifiable, $notification, $message)
52	3	{
53	3	$this->events->fire(
54	3	new NotificationFailed($notifiable, $notification, 'pushover', [$message])
55	3	);
56	1	}
57		}
58

laravel-notification-channels / pushover

Push — master ( f96e3c...dc495a )

PushoverChannel::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like