Channel::send() - Code Metrics - Inspection of "Update Readme" - laravel-notification-channels/pusher-push-notifications - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f5db3e...2711f4 )

by Mohamed

created 2016-08-11 20:32 UTC

Channel::send() A

↳ Parent: Channel

Complexity

Conditions	4
Paths	6

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	2

Metric	Value
c	4
b	0
f	2
dl	0
loc	21
rs	9.0534
cc	4
eloc	12
nc	6
nop	2

<?php

namespace NotificationChannels\PusherPushNotifications;

use NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification;
use NotificationChannels\PusherPushNotifications\Events\MessageWasSent;
use NotificationChannels\PusherPushNotifications\Events\SendingMessage;
use Illuminate\Notifications\Notification;
use Pusher;

class Channel
{
    /**
     * @var Pusher
     */
    protected $pusher;

    public function __construct($pusher)
    {
        $this->pusher = $pusher;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @return void
     * @throws \NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        $interest = $notifiable->routeNotificationFor('PusherPushNotifications')
            ?: $this->interestName($notifiable);

        if (! $this->shouldSendMessage($notifiable, $notification)) {
            return;
        }

        $response = $this->pusher->notify(
            $interest,
            $notification->toPushNotification($notifiable)->toArray(),
            true
        );

        if (! in_array($response['status'], [200, 202])) {
            throw CouldNotSendNotification::pusherRespondedWithAnError($response);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }

        event(new MessageWasSent($notifiable, $notification));
    }

    /**
     * Get the interest name for the notifiable.
     *
     * @param $notifiable
     *
     * @return string
     */
    protected function interestName($notifiable)
    {
        $class = str_replace('\\', '.', get_class($notifiable));

        return $class.'.'.$notifiable->getKey();
    }

    /**
     * Check if we can send the notification.
     *
     * @return bool
     */
    private function shouldSendMessage($notifiable, $notification)
    {
        return event(new SendingMessage($notifiable, $notification), [], true) !== false;
    }
}


1			<?php
2
3			namespace NotificationChannels\PusherPushNotifications;
4
5			use NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification;
6			use NotificationChannels\PusherPushNotifications\Events\MessageWasSent;
7			use NotificationChannels\PusherPushNotifications\Events\SendingMessage;
8			use Illuminate\Notifications\Notification;
9			use Pusher;
10
11			class Channel
12			{
13			/**
14			* @var Pusher
15			*/
16			protected $pusher;
17
18			public function __construct($pusher)
19			{
20			$this->pusher = $pusher;
21			}
22
23			/**
24			* Send the given notification.
25			*
26			* @param mixed $notifiable
27			* @param \Illuminate\Notifications\Notification $notification
28			*
29			* @return void
30			* @throws \NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification
31			*/
32			public function send($notifiable, Notification $notification)
33			{
34			$interest = $notifiable->routeNotificationFor('PusherPushNotifications')
35			?: $this->interestName($notifiable);
36
37			if (! $this->shouldSendMessage($notifiable, $notification)) {
38			return;
39			}
40
41			$response = $this->pusher->notify(
42			$interest,
43			$notification->toPushNotification($notifiable)->toArray(),
44			true
45			);
46
47			if (! in_array($response['status'], [200, 202])) {
48			throw CouldNotSendNotification::pusherRespondedWithAnError($response);
			0 ignored issues – show Bug introduced 2016-08-10 21:44 UTC by Report Bug Copy Issue Report It seems like `$response` defined by `$this->pusher->notify($i...able)->toArray(), true)` on line `41` can also be of type `boolean`; however, `NotificationChannels\Pus...rRespondedWithAnError()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
49			}
50
51			event(new MessageWasSent($notifiable, $notification));
52			}
53
54			/**
55			* Get the interest name for the notifiable.
56			*
57			* @param $notifiable
58			*
59			* @return string
60			*/
61			protected function interestName($notifiable)
62			{
63			$class = str_replace('\\', '.', get_class($notifiable));
64
65			return $class.'.'.$notifiable->getKey();
66			}
67
68			/**
69			* Check if we can send the notification.
70			*
71			* @return bool
72			*/
73			private function shouldSendMessage($notifiable, $notification)
74			{
75			return event(new SendingMessage($notifiable, $notification), [], true) !== false;
76			}
77			}
78

laravel-notification-channels / pusher-push-notifications

GitHub Access Token became invalid

Push — master ( f5db3e...2711f4 )

Channel::send() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like