Issues in Channel.php - New Issues - Inspection of "fix exception class name" - laravel-notification-channels/pusher-push-notifications - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3e1dfa...42641e )

by Mohamed

created 2016-08-10 22:35 UTC

src/Channel.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace NotificationChannels\PusherPushNotifications;

use Illuminate\Notifications\Notification;
use NotificationChannels\PusherPushNotifications\Events\MessageWasSent;
use NotificationChannels\PusherPushNotifications\Events\SendingMessage;
use NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification;
use Pusher;

class Channel
{
    /**
     * @var \Pusher
     */
    protected $pusher;

    public function __construct(Pusher $pusher)
    {
        $this->pusher = $pusher;
    }

    /**
     * Send the given notification.
     *
     * @param mixed                                  $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @return void
     * @throws \NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        $interest = $notifiable->routeNotificationFor('PusherPushNotifications') ?: $this->interestName($notifiable);

        $shouldSendMessage = event(new SendingMessage($notifiable, $notification), [], true) !== false;

        if (!$shouldSendMessage) {
            return;
        }

        $response = $this->pusher->notify(
            $interest,
            $notification->toPushNotification($notifiable)->toArray(),
            true
        );

        if (!in_array($response['status'], [200, 202])) {
            throw CouldNotSendNotification::pusherRespondedWithAnError($response);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }

        event(new MessageWasSent($notifiable, $notification));
    }

    /**
     * Get the interest name for the notifiable.
     *
     * @param $notifiable
     *
     * @return string
     */
    protected function interestName($notifiable)
    {
        $class = str_replace('\\', '.', get_class($notifiable));

        return $class.'.'.$notifiable->getKey();
    }
}


1			<?php
2
3			namespace NotificationChannels\PusherPushNotifications;
4
5			use Illuminate\Notifications\Notification;
6			use NotificationChannels\PusherPushNotifications\Events\MessageWasSent;
7			use NotificationChannels\PusherPushNotifications\Events\SendingMessage;
8			use NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification;
9			use Pusher;
10
11			class Channel
12			{
13			/**
14			* @var \Pusher
15			*/
16			protected $pusher;
17
18			public function __construct(Pusher $pusher)
19			{
20			$this->pusher = $pusher;
21			}
22
23			/**
24			* Send the given notification.
25			*
26			* @param mixed $notifiable
27			* @param \Illuminate\Notifications\Notification $notification
28			*
29			* @return void
30			* @throws \NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification
31			*/
32			public function send($notifiable, Notification $notification)
33			{
34			$interest = $notifiable->routeNotificationFor('PusherPushNotifications') ?: $this->interestName($notifiable);
35
36			$shouldSendMessage = event(new SendingMessage($notifiable, $notification), [], true) !== false;
37
38			if (!$shouldSendMessage) {
39			return;
40			}
41
42			$response = $this->pusher->notify(
43			$interest,
44			$notification->toPushNotification($notifiable)->toArray(),
45			true
46			);
47
48			if (!in_array($response['status'], [200, 202])) {
49			throw CouldNotSendNotification::pusherRespondedWithAnError($response);
			0 ignored issues – show Bug introduced 2016-08-10 21:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$response` defined by `$this->pusher->notify($i...able)->toArray(), true)` on line `42` can also be of type `boolean`; however, `NotificationChannels\Pus...rRespondedWithAnError()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
50			}
51
52			event(new MessageWasSent($notifiable, $notification));
53			}
54
55			/**
56			* Get the interest name for the notifiable.
57			*
58			* @param $notifiable
59			*
60			* @return string
61			*/
62			protected function interestName($notifiable)
63			{
64			$class = str_replace('\\', '.', get_class($notifiable));
65
66			return $class.'.'.$notifiable->getKey();
67			}
68			}
69

GitHub Access Token became invalid

Push — master ( 3e1dfa...42641e )

src/Channel.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

laravel-notification-channels / pusher-push-notifications

GitHub Access Token became invalid

Push — master ( 3e1dfa...42641e )

src/Channel.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like