laravel-notification-channels / pusher-push-notifications

src/PusherChannel.php

<?php

namespace NotificationChannels\PusherPushNotifications;

use NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification;
use Illuminate\Notifications\Notification;
use Pusher;

class PusherChannel
{
    /** @var Pusher */
    protected $pusher;

    /**
     * @param \Pusher $pusher
     */
    public function __construct(Pusher $pusher)
    {
        $this->pusher = $pusher;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @return void
     * @throws \NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        $interest = $notifiable->routeNotificationFor('PusherPushNotifications')
            ?: $this->interestName($notifiable);

        $response = $this->pusher->notify(
            $interest,
            $notification->toPushNotification($notifiable)->toArray(),
            true
        );

        if (! in_array($response['status'], [200, 202])) {
            throw CouldNotSendNotification::pusherRespondedWithAnError($response);

It seems like $response defined by $this->pusher->notify($interest, $notification->toPushNotification($notifiable)->toArray(), true) on line 36 can also be of type boolean; however, NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification::pusherRespondedWithAnError() does only seem to accept array, maybe add an additional type check?

        }
    }

    /**
     * Get the interest name for the notifiable.
     *
     * @param $notifiable
     *
     * @return string
     */
    protected function interestName($notifiable)
    {
        $class = str_replace('\\', '.', get_class($notifiable));

        return $class.'.'.$notifiable->getKey();
    }
}