PusherChannel::send() - Code Metrics - Inspection of "Fix tests and build (#41)" - laravel-notification-channels/pusher-push-notifications - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 223623...653a85 )

by Atymic

created 2020-01-02 10:21 UTC

PusherChannel::send() A

↳ Parent: PusherChannel

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	11
cts	11
cp	1
rs	9.7
c	0
b	0
f	0
cc	4
nc	4
nop	2
crap	4

<?php

namespace NotificationChannels\PusherPushNotifications;

use Pusher\Pusher;
use Illuminate\Events\Dispatcher;
use Illuminate\Notifications\Notification;
use Illuminate\Notifications\Events\NotificationFailed;

class PusherChannel
{
    /**
     * @var Pusher
     */
    protected $pusher;

    /**
     * @var \Illuminate\Events\Dispatcher
     */
    private $events;

    /**
     * @param Pusher $pusher
     */
    public function __construct(Pusher $pusher, Dispatcher $events)
    {
        $this->pusher = $pusher;
        $this->events = $events;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @return void
     */
    public function send($notifiable, Notification $notification)
    {
        $interest = $notifiable->routeNotificationFor('PusherPushNotifications')
            ?: $this->interestName($notifiable);

        $response = $this->pusher->notify(
            is_array($interest) ? $interest : [$interest],
            $notification->toPushNotification($notifiable)->toArray(),

            true
        );

        if (! in_array($response['status'], [200, 202])) {
            $this->events->fire(

                new NotificationFailed($notifiable, $notification, 'pusher-push-notifications', $response)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            );
        }
    }

    /**
     * Get the interest name for the notifiable.
     *
     * @param $notifiable
     *
     * @return string
     */
    protected function interestName($notifiable)
    {
        $class = str_replace('\\', '.', get_class($notifiable));

        return $class.'.'.$notifiable->getKey();
    }
}


1		<?php
2
3		namespace NotificationChannels\PusherPushNotifications;
4
5		use Pusher\Pusher;
6		use Illuminate\Events\Dispatcher;
7		use Illuminate\Notifications\Notification;
8		use Illuminate\Notifications\Events\NotificationFailed;
9
10		class PusherChannel
11		{
12		/**
13		* @var Pusher
14		*/
15		protected $pusher;
16
17		/**
18		* @var \Illuminate\Events\Dispatcher
19		*/
20		private $events;
21
22		/**
23		* @param Pusher $pusher
24		*/
25	2	public function __construct(Pusher $pusher, Dispatcher $events)
26		{
27	2	$this->pusher = $pusher;
28	2	$this->events = $events;
29	2	}
30
31		/**
32		* Send the given notification.
33		*
34		* @param mixed $notifiable
35		* @param \Illuminate\Notifications\Notification $notification
36		*
37		* @return void
38		*/
39	2	public function send($notifiable, Notification $notification)
40		{
41	2	$interest = $notifiable->routeNotificationFor('PusherPushNotifications')
42	2	?: $this->interestName($notifiable);
43
44	2	$response = $this->pusher->notify(
45	2	is_array($interest) ? $interest : [$interest],
46	2	$notification->toPushNotification($notifiable)->toArray(),
		0 ignored issues – show Bug introduced 2017-04-22 07:50 UTC by Report Bug Copy Issue Report The method `toPushNotification()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
47	2	true
48		);
49
50	2	if (! in_array($response['status'], [200, 202])) {
51	1	$this->events->fire(
		0 ignored issues – show Bug introduced 2019-09-12 22:43 UTC by Report Bug Copy Issue Report The method `fire()` does not seem to exist on `object<Illuminate\Events\Dispatcher>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
52	1	new NotificationFailed($notifiable, $notification, 'pusher-push-notifications', $response)
		0 ignored issues – show Bug introduced 2019-09-12 22:43 UTC by Report Bug Copy Issue Report It seems like `$response` defined by `$this->pusher->notify(is...able)->toArray(), true)` on line `44` can also be of type `boolean`; however, `Illuminate\Notifications...onFailed::__construct()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
53		);
54		}
55	2	}
56
57		/**
58		* Get the interest name for the notifiable.
59		*
60		* @param $notifiable
61		*
62		* @return string
63		*/
64		protected function interestName($notifiable)
65		{
66		$class = str_replace('\\', '.', get_class($notifiable));
67
68		return $class.'.'.$notifiable->getKey();
69		}
70		}
71

laravel-notification-channels / pusher-push-notifications

GitHub Access Token became invalid

Push — master ( 223623...653a85 )

PusherChannel::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like