PusherChannel::send() - Code Metrics - Inspection of "Update to Pusher Beams" - laravel-notification-channels/pusher-push-notifications - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#42)

unknown

created 2020-01-03 00:55 UTC

PusherChannel::send() A

↳ Parent: PusherChannel

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	10
cts	10
cp	1
rs	9.7333
c	0
b	0
f	0
cc	4
nc	4
nop	2
crap	4

<?php

namespace NotificationChannels\PusherPushNotifications;

use Illuminate\Events\Dispatcher;
use Illuminate\Notifications\Events\NotificationFailed;
use Illuminate\Notifications\Notification;
use Pusher\PushNotifications\PushNotifications;
use Throwable;

class PusherChannel
{
    /**
     * @var PushNotifications
     */
    protected $beamsClient;

    /**
     * @var \Illuminate\Events\Dispatcher
     */
    private $events;

    /**
     * @param Pusher $pusher
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct(PushNotifications $beamsClient, Dispatcher $events)
    {
        $this->beamsClient = $beamsClient;
        $this->events = $events;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @return void
     */
    public function send($notifiable, Notification $notification)
    {
        $interest = $notifiable->routeNotificationFor('PusherPushNotifications')
            ?: $this->interestName($notifiable);

        try {
            $this->beamsClient->publishToInterests(
                is_array($interest) ? $interest : [$interest],
                $notification->toPushNotification($notifiable)->toArray()

            );
        } catch (Throwable $exception) {
            $this->events->dispatch(
                new NotificationFailed($notifiable, $notification, 'pusher-push-notifications')
            );
        }
    }

    /**
     * Get the interest name for the notifiable.
     *
     * @param $notifiable
     *
     * @return string
     */
    protected function interestName($notifiable)
    {
        $class = str_replace('\\', '.', get_class($notifiable));

        return $class.'.'.$notifiable->getKey();
    }
}


1		<?php
2
3		namespace NotificationChannels\PusherPushNotifications;
4
5		use Illuminate\Events\Dispatcher;
6		use Illuminate\Notifications\Events\NotificationFailed;
7		use Illuminate\Notifications\Notification;
8		use Pusher\PushNotifications\PushNotifications;
9		use Throwable;
10
11		class PusherChannel
12		{
13		/**
14		* @var PushNotifications
15		*/
16		protected $beamsClient;
17
18		/**
19		* @var \Illuminate\Events\Dispatcher
20		*/
21		private $events;
22
23		/**
24		* @param Pusher $pusher
		0 ignored issues – show Bug introduced 2020-01-02 09:57 UTC by Report Bug Copy Issue Report There is no parameter named `$pusher`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
25		*/
26	2	public function __construct(PushNotifications $beamsClient, Dispatcher $events)
27		{
28	2	$this->beamsClient = $beamsClient;
29	2	$this->events = $events;
30	2	}
31
32		/**
33		* Send the given notification.
34		*
35		* @param mixed $notifiable
36		* @param \Illuminate\Notifications\Notification $notification
37		*
38		* @return void
39		*/
40	2	public function send($notifiable, Notification $notification)
41		{
42	2	$interest = $notifiable->routeNotificationFor('PusherPushNotifications')
43	2	?: $this->interestName($notifiable);
44
45		try {
46	2	$this->beamsClient->publishToInterests(
47	2	is_array($interest) ? $interest : [$interest],
48	2	$notification->toPushNotification($notifiable)->toArray()
		0 ignored issues – show Bug introduced 2017-04-22 07:50 UTC by Report Bug Copy Issue Report The method `toPushNotification()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
49		);
50	1	} catch (Throwable $exception) {
51	1	$this->events->dispatch(
52	1	new NotificationFailed($notifiable, $notification, 'pusher-push-notifications')
53		);
54		}
55	2	}
56
57		/**
58		* Get the interest name for the notifiable.
59		*
60		* @param $notifiable
61		*
62		* @return string
63		*/
64		protected function interestName($notifiable)
65		{
66		$class = str_replace('\\', '.', get_class($notifiable));
67
68		return $class.'.'.$notifiable->getKey();
69		}
70		}
71

laravel-notification-channels / pusher-push-notifications

GitHub Access Token became invalid

Pull Request — master (#42)

PusherChannel::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like