Issues in PusherChannel.php - New Issues - Inspection of "Merge pull request #14 from casperboone/patch-1" - laravel-notification-channels/pusher-push-notifications - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 286f9f...2ec875 )

by Mohamed

created 2016-08-25 12:03 UTC

src/PusherChannel.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace NotificationChannels\PusherPushNotifications;

use Pusher;
use Illuminate\Events\Dispatcher;
use Illuminate\Notifications\Notification;
use Illuminate\Notifications\Events\NotificationFailed;

class PusherChannel
{
    /**
     * @var \Pusher
     */
    protected $pusher;

    /**
     * @var \Illuminate\Events\Dispatcher
     */
    private $events;

    /**
     * @param \Pusher $pusher
     */
    public function __construct(Pusher $pusher, Dispatcher $events)
    {
        $this->pusher = $pusher;
        $this->events = $events;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @return void
     */
    public function send($notifiable, Notification $notification)
    {
        $interest = $notifiable->routeNotificationFor('PusherPushNotifications')
            ?: $this->interestName($notifiable);

        $response = $this->pusher->notify(
            $interest,
            $notification->toPushNotification($notifiable)->toArray(),
            true
        );

        if (! in_array($response['status'], [200, 202])) {
            $this->events->fire(
                new NotificationFailed($notifiable, $notification, 'pusher-push-notifications', $response)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            );
        }
    }

    /**
     * Get the interest name for the notifiable.
     *
     * @param $notifiable
     *
     * @return string
     */
    protected function interestName($notifiable)
    {
        $class = str_replace('\\', '.', get_class($notifiable));

        return $class.'.'.$notifiable->getKey();
    }
}


1		<?php
2
3		namespace NotificationChannels\PusherPushNotifications;
4
5		use Pusher;
6		use Illuminate\Events\Dispatcher;
7		use Illuminate\Notifications\Notification;
8		use Illuminate\Notifications\Events\NotificationFailed;
9
10		class PusherChannel
11		{
12		/**
13		* @var \Pusher
14		*/
15		protected $pusher;
16
17		/**
18		* @var \Illuminate\Events\Dispatcher
19		*/
20		private $events;
21
22		/**
23		* @param \Pusher $pusher
24		*/
25	2	public function __construct(Pusher $pusher, Dispatcher $events)
26		{
27	2	$this->pusher = $pusher;
28	2	$this->events = $events;
29	2	}
30
31		/**
32		* Send the given notification.
33		*
34		* @param mixed $notifiable
35		* @param \Illuminate\Notifications\Notification $notification
36		*
37		* @return void
38		*/
39	2	public function send($notifiable, Notification $notification)
40		{
41	2	$interest = $notifiable->routeNotificationFor('PusherPushNotifications')
42	2	?: $this->interestName($notifiable);
43
44	2	$response = $this->pusher->notify(
45	2	$interest,
46	2	$notification->toPushNotification($notifiable)->toArray(),
47		true
48	2	);
49
50	2	if (! in_array($response['status'], [200, 202])) {
51	1	$this->events->fire(
52	1	new NotificationFailed($notifiable, $notification, 'pusher-push-notifications', $response)
		0 ignored issues – show Bug introduced 2016-08-25 12:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$response` defined by `$this->pusher->notify($i...able)->toArray(), true)` on line `44` can also be of type `boolean`; however, `Illuminate\Notifications...onFailed::__construct()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
53	1	);
54	1	}
55	2	}
56
57		/**
58		* Get the interest name for the notifiable.
59		*
60		* @param $notifiable
61		*
62		* @return string
63		*/
64		protected function interestName($notifiable)
65		{
66		$class = str_replace('\\', '.', get_class($notifiable));
67
68		return $class.'.'.$notifiable->getKey();
69		}
70		}
71

GitHub Access Token became invalid

Push — master ( 286f9f...2ec875 )

src/PusherChannel.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

laravel-notification-channels / pusher-push-notifications

GitHub Access Token became invalid

Push — master ( 286f9f...2ec875 )

src/PusherChannel.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like