PusherChannel::send() - Code Metrics - Inspection of "prepare for release" - laravel-notification-channels/pusher-push-notifications - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a7f99e...504e43 )

by Mohamed

created 2016-08-23 14:04 UTC

PusherChannel::send() A

↳ Parent: PusherChannel

Complexity

Conditions	3
Paths	4

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	15
rs	9.4285
cc	3
eloc	9
nc	4
nop	2

<?php

namespace NotificationChannels\PusherPushNotifications;

use NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification;
use Illuminate\Notifications\Notification;
use Pusher;

class PusherChannel
{
    /** @var Pusher */
    protected $pusher;

    /**
     * @param \Pusher $pusher
     */
    public function __construct(Pusher $pusher)
    {
        $this->pusher = $pusher;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @return void
     * @throws \NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        $interest = $notifiable->routeNotificationFor('PusherPushNotifications')
            ?: $this->interestName($notifiable);

        $response = $this->pusher->notify(
            $interest,
            $notification->toPushNotification($notifiable)->toArray(),
            true
        );

        if (! in_array($response['status'], [200, 202])) {
            throw CouldNotSendNotification::pusherRespondedWithAnError($response);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        }
    }

    /**
     * Get the interest name for the notifiable.
     *
     * @param $notifiable
     *
     * @return string
     */
    protected function interestName($notifiable)
    {
        $class = str_replace('\\', '.', get_class($notifiable));

        return $class.'.'.$notifiable->getKey();
    }
}


1			<?php
2
3			namespace NotificationChannels\PusherPushNotifications;
4
5			use NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification;
6			use Illuminate\Notifications\Notification;
7			use Pusher;
8
9			class PusherChannel
10			{
11			/** @var Pusher */
12			protected $pusher;
13
14			/**
15			* @param \Pusher $pusher
16			*/
17			public function __construct(Pusher $pusher)
18			{
19			$this->pusher = $pusher;
20			}
21
22			/**
23			* Send the given notification.
24			*
25			* @param mixed $notifiable
26			* @param \Illuminate\Notifications\Notification $notification
27			*
28			* @return void
29			* @throws \NotificationChannels\PusherPushNotifications\Exceptions\CouldNotSendNotification
30			*/
31			public function send($notifiable, Notification $notification)
32			{
33			$interest = $notifiable->routeNotificationFor('PusherPushNotifications')
34			?: $this->interestName($notifiable);
35
36			$response = $this->pusher->notify(
37			$interest,
38			$notification->toPushNotification($notifiable)->toArray(),
39			true
40			);
41
42			if (! in_array($response['status'], [200, 202])) {
43			throw CouldNotSendNotification::pusherRespondedWithAnError($response);
			0 ignored issues – show Bug introduced 2016-08-10 21:44 UTC by Report Bug Copy Issue Report It seems like `$response` defined by `$this->pusher->notify($i...able)->toArray(), true)` on line `36` can also be of type `boolean`; however, `NotificationChannels\Pus...rRespondedWithAnError()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
44			}
45			}
46
47			/**
48			* Get the interest name for the notifiable.
49			*
50			* @param $notifiable
51			*
52			* @return string
53			*/
54			protected function interestName($notifiable)
55			{
56			$class = str_replace('\\', '.', get_class($notifiable));
57
58			return $class.'.'.$notifiable->getKey();
59			}
60			}
61

laravel-notification-channels / pusher-push-notifications

GitHub Access Token became invalid

Push — master ( a7f99e...504e43 )

PusherChannel::send() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like