PusherChannel::send() - Code Metrics - Inspection of "Update to Mockery 1" - laravel-notification-channels/pusher-push-notifications - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#25)

unknown

created 2017-11-09 11:15 UTC

PusherChannel::send() A

↳ Parent: PusherChannel

Complexity

Conditions	3
Paths	4

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	0
cts	15
cp	0
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	10
nc	4
nop	2
crap	12

<?php

namespace NotificationChannels\PusherPushNotifications;

use Pusher;
use Illuminate\Events\Dispatcher;
use Illuminate\Notifications\Notification;
use Illuminate\Notifications\Events\NotificationFailed;

class PusherChannel
{
    /**
     * @var \Pusher
     */
    protected $pusher;

    /**
     * @var \Illuminate\Events\Dispatcher
     */
    private $events;

    /**
     * @param \Pusher $pusher
     */
    public function __construct(Pusher $pusher, Dispatcher $events)
    {
        $this->pusher = $pusher;
        $this->events = $events;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @return void
     */
    public function send($notifiable, Notification $notification)
    {
        $interest = $notifiable->routeNotificationFor('PusherPushNotifications')
            ?: $this->interestName($notifiable);

        $response = $this->pusher->notify(
            $interest,
            $notification->toPushNotification($notifiable)->toArray(),

            true
        );

        if (! in_array($response['status'], [200, 202])) {
            $this->events->fire(
                new NotificationFailed($notifiable, $notification, 'pusher-push-notifications', $response)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            );
        }
    }

    /**
     * Get the interest name for the notifiable.
     *
     * @param $notifiable
     *
     * @return string
     */
    protected function interestName($notifiable)
    {
        $class = str_replace('\\', '.', get_class($notifiable));

        return $class.'.'.$notifiable->getKey();
    }
}


1			<?php
2
3			namespace NotificationChannels\PusherPushNotifications;
4
5			use Pusher;
6			use Illuminate\Events\Dispatcher;
7			use Illuminate\Notifications\Notification;
8			use Illuminate\Notifications\Events\NotificationFailed;
9
10			class PusherChannel
11			{
12			/**
13			* @var \Pusher
14			*/
15			protected $pusher;
16
17			/**
18			* @var \Illuminate\Events\Dispatcher
19			*/
20			private $events;
21
22			/**
23			* @param \Pusher $pusher
24			*/
25			public function __construct(Pusher $pusher, Dispatcher $events)
26			{
27			$this->pusher = $pusher;
28			$this->events = $events;
29			}
30
31			/**
32			* Send the given notification.
33			*
34			* @param mixed $notifiable
35			* @param \Illuminate\Notifications\Notification $notification
36			*
37			* @return void
38			*/
39			public function send($notifiable, Notification $notification)
40			{
41			$interest = $notifiable->routeNotificationFor('PusherPushNotifications')
42			?: $this->interestName($notifiable);
43
44			$response = $this->pusher->notify(
45			$interest,
46			$notification->toPushNotification($notifiable)->toArray(),
			0 ignored issues – show Bug introduced 2017-04-22 07:50 UTC by Report Bug Copy Issue Report The method `toPushNotification()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
47			true
48			);
49
50			if (! in_array($response['status'], [200, 202])) {
51			$this->events->fire(
52			new NotificationFailed($notifiable, $notification, 'pusher-push-notifications', $response)
			0 ignored issues – show Bug introduced 2016-08-25 12:05 UTC by Report Bug Copy Issue Report It seems like `$response` defined by `$this->pusher->notify($i...able)->toArray(), true)` on line `44` can also be of type `boolean`; however, `Illuminate\Notifications...onFailed::__construct()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
53			);
54			}
55			}
56
57			/**
58			* Get the interest name for the notifiable.
59			*
60			* @param $notifiable
61			*
62			* @return string
63			*/
64			protected function interestName($notifiable)
65			{
66			$class = str_replace('\\', '.', get_class($notifiable));
67
68			return $class.'.'.$notifiable->getKey();
69			}
70			}
71

laravel-notification-channels / pusher-push-notifications

GitHub Access Token became invalid

Pull Request — master (#25)

PusherChannel::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like