Email::__construct() - Code Metrics - Inspection of "fix: Made properties in targets private, added tes..." - laravel-notification-channels/pushbullet - Measure and Improve Code Quality continuously with Scrutinizer

pushbullet

Completed

Push — master ( 470965...f7c466 )

by Alexey

created 2020-09-13 13:07 UTC

Email::__construct() A

↳ Parent: Email

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php

namespace NotificationChannels\Pushbullet\Targets;

use NotificationChannels\Pushbullet\Exceptions\CouldNotSendNotification;

class Email implements Targetable
{
    /**
     * Recipient email.
     *
     * @var string
     */
    private $email;

    /**
     * Set recipient email.
     *
     * @param  string  $email
     */
    public function __construct($email)
    {
        if (filter_var($email, FILTER_VALIDATE_EMAIL) === false) {
            throw CouldNotSendNotification::providedEmailIsInvalid($email);
        }

        $this->email = $email;
    }

    /**
     * {@inheritdoc}
     */
    public function getTarget()
    {
        return ['email' => $this->email];
    }
}


1		<?php
2
3		namespace NotificationChannels\Pushbullet\Targets;
4
5		use NotificationChannels\Pushbullet\Exceptions\CouldNotSendNotification;
6
7		class Email implements Targetable
8		{
9		/**
10		* Recipient email.
11		*
12		* @var string
13		*/
14		private $email;
15
16		/**
17		* Set recipient email.
18		*
19		* @param string $email
20		*/
21	2	public function __construct($email)
22		{
23	2	if (filter_var($email, FILTER_VALIDATE_EMAIL) === false) {
24	1	throw CouldNotSendNotification::providedEmailIsInvalid($email);
25		}
26
27	1	$this->email = $email;
28	1	}
29
30		/**
31		* {@inheritdoc}
32		*/
33	1	public function getTarget()
34		{
35	1	return ['email' => $this->email];
36		}
37		}
38

laravel-notification-channels / pushbullet

GitHub Access Token became invalid

Push — master ( 470965...f7c466 )

Email::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like