Issues in Deprecated.php (master) - Issues in master - laravel-notification-channels/onesignal - Measure and Improve Code Quality continuously with Scrutinizer

Issues (38)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Traits/Deprecated.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace NotificationChannels\OneSignal\Traits;

use NotificationChannels\OneSignal\OneSignalButton;
use NotificationChannels\OneSignal\OneSignalWebButton;

trait Deprecated
{
    /**
     * Set the message body.
     *
     * @param mixed $value
     *
     * @deprecated use setBody instead
     *
     * @return $this
     */
    public function body($value)
    {
        return $this->setBody($value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the message subject.
     *
     * @param mixed $value
     *
     * @deprecated Use setSubject instead
     *
     * @return $this
     */
    public function subject($value)
    {
        return $this->setParameter('headings', $this->parseValueToArray($value));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the message url.
     *
     * @param string $value
     *
     * @deprecated use setUrl Instead
     *
     * @return $this
     */
    public function url($value)
    {
        return $this->setUrl($value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Add a web button to the message.
     *
     * @param OneSignalWebButton $button
     *
     * @deprecated use setWebButton instead
     *
     * @return $this
     */
    public function webButton(OneSignalWebButton $button)
    {
        return $this->setWebButton($button);

    }

    /**
     * Adds more than one web button to the message.
     *
     * @param array[OnSignalWebButton] $buttons

     *
     * @deprecated use setWebButtons instead
     *
     * @return $this
     */
    public function webButtons(array $buttons)
    {
        return $this->setWebButtons($buttons);

    }

    /**
     * Add a native button to the message.
     *
     * @param OneSignalButton $button
     *
     * @deprecated use setButton instead
     * @return $this
     */
    public function button(OneSignalButton $button)
    {
        return $this->setButton($button);

    }

    /**
     * Adds more than one native button to the message.
     *
     * @param array $buttons
     *
     * @deprecated use setButtons instead
     *
     * @return $this
     */
    public function buttons(array $buttons)
    {
        return $this->setButtons($buttons);

    }
}


1		<?php
2
3		namespace NotificationChannels\OneSignal\Traits;
4
5		use NotificationChannels\OneSignal\OneSignalButton;
6		use NotificationChannels\OneSignal\OneSignalWebButton;
7
8		trait Deprecated
9		{
10		/**
11		* Set the message body.
12		*
13		* @param mixed $value
14		*
15		* @deprecated use setBody instead
16		*
17		* @return $this
18		*/
19		public function body($value)
20		{
21		return $this->setBody($value);
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `setBody()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22		}
23
24		/**
25		* Set the message subject.
26		*
27		* @param mixed $value
28		*
29		* @deprecated Use setSubject instead
30		*
31		* @return $this
32		*/
33	9	public function subject($value)
34		{
35	9	return $this->setParameter('headings', $this->parseValueToArray($value));
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `parseValueToArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36		}
37
38		/**
39		* Set the message url.
40		*
41		* @param string $value
42		*
43		* @deprecated use setUrl Instead
44		*
45		* @return $this
46		*/
47	9	public function url($value)
48		{
49	9	return $this->setUrl($value);
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `setUrl()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
50		}
51
52		/**
53		* Add a web button to the message.
54		*
55		* @param OneSignalWebButton $button
56		*
57		* @deprecated use setWebButton instead
58		*
59		* @return $this
60		*/
61	1	public function webButton(OneSignalWebButton $button)
62		{
63	1	return $this->setWebButton($button);
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setWebButton()` does not exist on `NotificationChannels\OneSignal\Traits\Deprecated`. Did you maybe mean `webButton()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
64		}
65
66		/**
67		* Adds more than one web button to the message.
68		*
69		* @param array[OnSignalWebButton] $buttons
		0 ignored issues – show Documentation introduced 2018-03-14 06:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The doc-type `array[OnSignalWebButton]` could not be parsed: Expected "]" at position 2, but found "OnSignalWebButton". (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
70		*
71		* @deprecated use setWebButtons instead
72		*
73		* @return $this
74		*/
75		public function webButtons(array $buttons)
76		{
77		return $this->setWebButtons($buttons);
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setWebButtons()` does not exist on `NotificationChannels\OneSignal\Traits\Deprecated`. Did you maybe mean `webButton()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
78		}
79
80		/**
81		* Add a native button to the message.
82		*
83		* @param OneSignalButton $button
84		*
85		* @deprecated use setButton instead
86		* @return $this
87		*/
88		public function button(OneSignalButton $button)
89		{
90		return $this->setButton($button);
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setButton()` does not exist on `NotificationChannels\OneSignal\Traits\Deprecated`. Did you maybe mean `button()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
91		}
92
93		/**
94		* Adds more than one native button to the message.
95		*
96		* @param array $buttons
97		*
98		* @deprecated use setButtons instead
99		*
100		* @return $this
101		*/
102		public function buttons(array $buttons)
103		{
104		return $this->setButtons($buttons);
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `setButtons()` does not exist on `NotificationChannels\OneSignal\Traits\Deprecated`. Did you maybe mean `button()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
105		}
106		}
107

GitHub Access Token became invalid

Issues (38)

Security Analysis no request data

src/Traits/Deprecated.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

laravel-notification-channels / onesignal

GitHub Access Token became invalid

Issues (38)

Security Analysis no request data

src/Traits/Deprecated.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like