Deprecated - Code Metrics - Inspection of "[WIP]Refactor to Traits and add some little more P..." - laravel-notification-channels/onesignal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

by Lukas

created 2018-08-09 08:14 UTC

Deprecated A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

42.86%

Importance

Changes

Metric	Value
wmc	7
c	0
b	0
f	0
lcom	0
cbo	0
dl	0
loc	99
ccs	6
cts	14
cp	0.4286
rs	10

7 Methods

Rating	Name	Size	Complexity
A	body()	4	1
A	subject()	4	1
A	url()	4	1
A	webButton()	4	1
A	webButtons()	4	1
A	button()	4	1
A	buttons()	4	1

<?php
/**
 * Created by PhpStorm.
 * User: lukaskammerling
 * Date: 15.03.18
 * Time: 09:03
 */

namespace NotificationChannels\OneSignal\Traits;


use NotificationChannels\OneSignal\OneSignalButton;
use NotificationChannels\OneSignal\OneSignalWebButton;

trait Deprecated
{
    /**
     * Set the message body.
     *
     * @param mixed $value
     *
     * @deprecated use setBody instead
     *
     * @return $this
     */
    public function body($value)
    {
        return $this->setBody($value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the message subject.
     *
     * @param mixed $value
     *
     * @deprecated Use setSubject instead
     *
     * @return $this
     */
    public function subject($value)
    {
        return $this->setParameter('headings', $this->parseValueToArray($value));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the message url.
     *
     * @param string $value
     *
     * @deprecated use setUrl Instead
     *
     * @return $this
     */
    public function url($value)
    {
        return $this->setUrl($value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Add a web button to the message.
     *
     * @param OneSignalWebButton $button
     *
     * @deprecated use setWebButton instead
     *
     * @return $this
     */
    public function webButton(OneSignalWebButton $button)
    {
        return $this->setWebButton($button);

    }

    /**
     * Adds more than one web button to the message.
     *
     * @param array[OnSignalWebButton] $buttons

     *
     * @deprecated use setWebButtons instead
     *
     * @return $this
     */
    public function webButtons(array $buttons)
    {
        return $this->setWebButtons($buttons);

    }

    /**
     * Add a native button to the message.
     *
     * @param OneSignalButton $button
     *
     * @deprecated use setButton instead
     * @return $this
     */
    public function button(OneSignalButton $button)
    {
        return $this->setButton($button);

    }

    /**
     * Adds more than one native button to the message.
     *
     * @param array $buttons
     *
     * @deprecated use setButtons instead
     *
     * @return $this
     */
    public function buttons(array $buttons)
    {
        return $this->setButtons($buttons);

    }
}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: lukaskammerling
5		* Date: 15.03.18
6		* Time: 09:03
7		*/
8
9		namespace NotificationChannels\OneSignal\Traits;
10
11
12		use NotificationChannels\OneSignal\OneSignalButton;
13		use NotificationChannels\OneSignal\OneSignalWebButton;
14
15		trait Deprecated
16		{
17		/**
18		* Set the message body.
19		*
20		* @param mixed $value
21		*
22		* @deprecated use setBody instead
23		*
24		* @return $this
25		*/
26		public function body($value)
27		{
28		return $this->setBody($value);
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report It seems like `setBody()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29		}
30
31		/**
32		* Set the message subject.
33		*
34		* @param mixed $value
35		*
36		* @deprecated Use setSubject instead
37		*
38		* @return $this
39		*/
40	5	public function subject($value)
41		{
42	5	return $this->setParameter('headings', $this->parseValueToArray($value));
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report It seems like `parseValueToArray()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
43		}
44
45		/**
46		* Set the message url.
47		*
48		* @param string $value
49		*
50		* @deprecated use setUrl Instead
51		*
52		* @return $this
53		*/
54	5	public function url($value)
55		{
56	5	return $this->setUrl($value);
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report It seems like `setUrl()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
57		}
58
59		/**
60		* Add a web button to the message.
61		*
62		* @param OneSignalWebButton $button
63		*
64		* @deprecated use setWebButton instead
65		*
66		* @return $this
67		*/
68	1	public function webButton(OneSignalWebButton $button)
69		{
70	1	return $this->setWebButton($button);
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report The method `setWebButton()` does not exist on `NotificationChannels\OneSignal\Traits\Deprecated`. Did you maybe mean `webButton()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
71		}
72
73		/**
74		* Adds more than one web button to the message.
75		*
76		* @param array[OnSignalWebButton] $buttons
		0 ignored issues – show Documentation introduced 2018-03-14 06:32 UTC by Report Bug Copy Issue Report The doc-type `array[OnSignalWebButton]` could not be parsed: Expected "]" at position 2, but found "OnSignalWebButton". (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
77		*
78		* @deprecated use setWebButtons instead
79		*
80		* @return $this
81		*/
82		public function webButtons(array $buttons)
83		{
84		return $this->setWebButtons($buttons);
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report The method `setWebButtons()` does not exist on `NotificationChannels\OneSignal\Traits\Deprecated`. Did you maybe mean `webButton()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
85		}
86
87		/**
88		* Add a native button to the message.
89		*
90		* @param OneSignalButton $button
91		*
92		* @deprecated use setButton instead
93		* @return $this
94		*/
95		public function button(OneSignalButton $button)
96		{
97		return $this->setButton($button);
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report The method `setButton()` does not exist on `NotificationChannels\OneSignal\Traits\Deprecated`. Did you maybe mean `button()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
98		}
99
100		/**
101		* Adds more than one native button to the message.
102		*
103		* @param array $buttons
104		*
105		* @deprecated use setButtons instead
106		*
107		* @return $this
108		*/
109		public function buttons(array $buttons)
110		{
111		return $this->setButtons($buttons);
		0 ignored issues – show Bug introduced 2018-03-15 08:11 UTC by Report Bug Copy Issue Report The method `setButtons()` does not exist on `NotificationChannels\OneSignal\Traits\Deprecated`. Did you maybe mean `button()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
112		}
113		}

laravel-notification-channels / onesignal

GitHub Access Token became invalid

Pull Request — master (#58)

Deprecated A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like