AttachmentHelpers::setChromeBigPicture() - Code Metrics - Inspection of "Pass the notification object to the routeNotificat..." - laravel-notification-channels/onesignal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#64)

unknown

created 2018-04-20 13:15 UTC

AttachmentHelpers::setChromeBigPicture() A

↳ Parent: AttachmentHelpers

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace NotificationChannels\OneSignal\Traits\Categories;

trait AttachmentHelpers
{
    /**
     * Set an Image/more than one Image only for iOS.
     *
     * @param string|array $imageUrl
     *
     * @return $this
     */
    public function setIosAttachment($imageUrl)
    {
        $imageUrl = is_array($imageUrl) ? $imageUrl : ['id1' => $imageUrl];
        return $this->setParameter('ios_attachments', $imageUrl);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the Big Picture Image only for Android.
     *
     * @param string $imageUrl
     *
     * @return $this
     */
    public function setAndroidBigPicture(string $imageUrl)
    {
        return $this->setParameter('big_picture', $imageUrl);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the Big Picture Image only for FireOS (Amazon).
     *
     * @param string $imageUrl
     *
     * @return $this
     */
    public function setAmazonBigPicture(string $imageUrl)
    {
        return $this->setParameter('adm_big_picture', $imageUrl);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the Big Picture Image only for Chrome.
     *
     * @param string $imageUrl
     *
     * @return $this
     */
    public function setChromeBigPicture(string $imageUrl)
    {
        return $this->setParameter('chrome_big_picture', $imageUrl);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the additional URL for all Platforms.
     *
     * @param string $url
     *
     * @return $this
     */
    public function setUrl(string $url)
    {
        return $this->setParameter('url', $url);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set an image to all possible attachment variables.
     *
     * @param string $imageUrl
     *
     * @return $this
     */
    public function setImageAttachments(string $imageUrl)
    {
        return $this->setIosAttachment($imageUrl)
            ->setAndroidBigPicture($imageUrl)
            ->setAmazonBigPicture($imageUrl)
            ->setChromeBigPicture($imageUrl);
    }
}


1		<?php
2
3		namespace NotificationChannels\OneSignal\Traits\Categories;
4
5		trait AttachmentHelpers
6		{
7		/**
8		* Set an Image/more than one Image only for iOS.
9		*
10		* @param string\|array $imageUrl
11		*
12		* @return $this
13		*/
14	1	public function setIosAttachment($imageUrl)
15		{
16	1	$imageUrl = is_array($imageUrl) ? $imageUrl : ['id1' => $imageUrl];
17	1	return $this->setParameter('ios_attachments', $imageUrl);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
18		}
19
20		/**
21		* Set the Big Picture Image only for Android.
22		*
23		* @param string $imageUrl
24		*
25		* @return $this
26		*/
27	1	public function setAndroidBigPicture(string $imageUrl)
28		{
29	1	return $this->setParameter('big_picture', $imageUrl);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30		}
31
32		/**
33		* Set the Big Picture Image only for FireOS (Amazon).
34		*
35		* @param string $imageUrl
36		*
37		* @return $this
38		*/
39	1	public function setAmazonBigPicture(string $imageUrl)
40		{
41	1	return $this->setParameter('adm_big_picture', $imageUrl);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
42		}
43
44		/**
45		* Set the Big Picture Image only for Chrome.
46		*
47		* @param string $imageUrl
48		*
49		* @return $this
50		*/
51	1	public function setChromeBigPicture(string $imageUrl)
52		{
53	1	return $this->setParameter('chrome_big_picture', $imageUrl);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
54		}
55
56		/**
57		* Set the additional URL for all Platforms.
58		*
59		* @param string $url
60		*
61		* @return $this
62		*/
63	6	public function setUrl(string $url)
64		{
65	6	return $this->setParameter('url', $url);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
66		}
67
68		/**
69		* Set an image to all possible attachment variables.
70		*
71		* @param string $imageUrl
72		*
73		* @return $this
74		*/
75	1	public function setImageAttachments(string $imageUrl)
76		{
77	1	return $this->setIosAttachment($imageUrl)
78	1	->setAndroidBigPicture($imageUrl)
79	1	->setAmazonBigPicture($imageUrl)
80	1	->setChromeBigPicture($imageUrl);
81		}
82		}
83

laravel-notification-channels / onesignal

GitHub Access Token became invalid

Pull Request — master (#64)

AttachmentHelpers::setChromeBigPicture() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like