GroupingHelpers - Code Metrics - Inspection of "[WIP]Refactor to Traits and add some little more P..." - laravel-notification-channels/onesignal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

by Lukas

created 2018-03-14 06:40 UTC

GroupingHelpers A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	0
dl	0
loc	42
ccs	0
cts	9
cp	0
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	setAndroidGroup()	5	1
A	setAmazonGroup()	5	1
A	setGroup()	5	1

<?php

namespace NotificationChannels\OneSignal\Traits\Categories;


trait GroupingHelpers
{

    /**
     * Set the Android Grouping Parameters
     * @param string $group
     * @param array  $groupMessage
     *
     * @return $this
     */
    public function setAndroidGroup(string $group, array $groupMessage)
    {
        return $this->setParameter('android_group',$group)
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->setParameter('android_group_message',$groupMessage);
    }

    /**
     * Set the Amazon (FireOS) Grouping Parameters
     * @param string $group
     * @param array  $groupMessage
     *
     * @return $this
     */
    public function setAmazonGroup(string $group, array $groupMessage)
    {
        return $this->setParameter('adm_group',$group)
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->setParameter('adm_group_message',$groupMessage);
    }

    /**
     * Set the Grouping Parameters for all available Systems (currently Android and Amazon (FireOs))
     * @param string $group
     * @param array  $groupMessage
     *
     * @return $this
     */
    public function setGroup(string $group, array $groupMessage)
    {
        return $this->setAndroidGroup($group,$groupMessage)
            ->setAmazonGroup($group,$groupMessage);
    }
}

1			<?php
2
3			namespace NotificationChannels\OneSignal\Traits\Categories;
4
5
6			trait GroupingHelpers
7			{
8
9			/**
10			* Set the Android Grouping Parameters
11			* @param string $group
12			* @param array $groupMessage
13			*
14			* @return $this
15			*/
16			public function setAndroidGroup(string $group, array $groupMessage)
17			{
18			return $this->setParameter('android_group',$group)
			0 ignored issues – show Bug introduced 2018-03-14 06:23 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19			->setParameter('android_group_message',$groupMessage);
20			}
21
22			/**
23			* Set the Amazon (FireOS) Grouping Parameters
24			* @param string $group
25			* @param array $groupMessage
26			*
27			* @return $this
28			*/
29			public function setAmazonGroup(string $group, array $groupMessage)
30			{
31			return $this->setParameter('adm_group',$group)
			0 ignored issues – show Bug introduced 2018-03-14 06:23 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32			->setParameter('adm_group_message',$groupMessage);
33			}
34
35			/**
36			* Set the Grouping Parameters for all available Systems (currently Android and Amazon (FireOs))
37			* @param string $group
38			* @param array $groupMessage
39			*
40			* @return $this
41			*/
42			public function setGroup(string $group, array $groupMessage)
43			{
44			return $this->setAndroidGroup($group,$groupMessage)
45			->setAmazonGroup($group,$groupMessage);
46			}
47			}

laravel-notification-channels / onesignal

GitHub Access Token became invalid

Pull Request — master (#58)

GroupingHelpers A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like