DeliveryHelpers - Code Metrics - Inspection of "[WIP]Refactor to Traits and add some little more P..." - laravel-notification-channels/onesignal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

by Lukas

created 2018-03-14 06:40 UTC

DeliveryHelpers A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	5
c	0
b	0
f	0
lcom	0
cbo	0
dl	0
loc	64
ccs	0
cts	10
cp	0
rs	10

5 Methods

Rating	Name	Size	Complexity
A	setSendAfter()	4	1
A	setDelayedOption()	4	1
A	setDeliveryTimeOfDay()	4	1
A	setTTL()	4	1
A	setPriority()	4	1

<?php

namespace NotificationChannels\OneSignal\Traits\Categories;


trait DeliveryHelpers
{

    /**
     * Set the send after
     *
     * @param string $date
     *
     * @return $this
     */
    public function setSendAfter(string $date)
    {
        return $this->setParameter('send_after',$date);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the deplayed option
     *
     * @param string $delayedOption
     *
     * @return $this
     */
    public function setDelayedOption(string $delayedOption)
    {
        return $this->setParameter('delayed_option', $delayedOption);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the delivery at time of the day. Use with delayed option = timezone
     *
     * @param string $timeOfDay
     *
     * @return $this
     */
    public function setDeliveryTimeOfDay(string $timeOfDay)
    {
        return $this->setParameter('delivery_time_of_day', $timeOfDay);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the Time to Live in Seconds
     *
     * @param int $ttl
     *
     * @return $this
     */
    public function setTTL(int $ttl)
    {
        return $this->setParameter('ttl', $ttl);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the Priority
     *
     * @param int $priority
     *
     * @return $this
     */
    public function setPriority(string $priority)
    {
        return $this->setParameter('priority', $priority);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

}

1			<?php
2
3			namespace NotificationChannels\OneSignal\Traits\Categories;
4
5
6			trait DeliveryHelpers
7			{
8
9			/**
10			* Set the send after
11			*
12			* @param string $date
13			*
14			* @return $this
15			*/
16			public function setSendAfter(string $date)
17			{
18			return $this->setParameter('send_after',$date);
			0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19			}
20
21			/**
22			* Set the deplayed option
23			*
24			* @param string $delayedOption
25			*
26			* @return $this
27			*/
28			public function setDelayedOption(string $delayedOption)
29			{
30			return $this->setParameter('delayed_option', $delayedOption);
			0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31			}
32
33			/**
34			* Set the delivery at time of the day. Use with delayed option = timezone
35			*
36			* @param string $timeOfDay
37			*
38			* @return $this
39			*/
40			public function setDeliveryTimeOfDay(string $timeOfDay)
41			{
42			return $this->setParameter('delivery_time_of_day', $timeOfDay);
			0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
43			}
44
45			/**
46			* Set the Time to Live in Seconds
47			*
48			* @param int $ttl
49			*
50			* @return $this
51			*/
52			public function setTTL(int $ttl)
53			{
54			return $this->setParameter('ttl', $ttl);
			0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
55			}
56
57			/**
58			* Set the Priority
59			*
60			* @param int $priority
61			*
62			* @return $this
63			*/
64			public function setPriority(string $priority)
65			{
66			return $this->setParameter('priority', $priority);
			0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
67			}
68
69			}

laravel-notification-channels / onesignal

GitHub Access Token became invalid

Pull Request — master (#58)

DeliveryHelpers A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like