AppearanceHelpers - Code Metrics - Inspection of "[WIP]Refactor to Traits and add some little more P..." - laravel-notification-channels/onesignal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

by Lukas

created 2018-03-14 06:40 UTC

AppearanceHelpers A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	106
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

58.33%

Importance

Changes

Metric	Value
wmc	8
c	0
b	0
f	0
lcom	1
cbo	0
dl	0
loc	106
ccs	14
cts	24
cp	0.5833
rs	10

8 Methods

Rating	Name	Size	Complexity
A	incrementIosBadgeCount()	5	1
A	decrementIosBadgeCount()	5	1
A	setIosBadgeCount()	5	1
A	setIosSound()	4	1
A	setAndroidSound()	4	1
A	setWindowsSound()	4	1
A	setSound()	6	1
A	icon()	6	1

<?php

namespace NotificationChannels\OneSignal\Traits\Categories;


trait AppearanceHelpers
{

    /**
     * Set the iOS badge increment count.
     *
     * @param int $count
     *
     * @return $this
     */
    public function incrementIosBadgeCount(int $count = 1)
    {
        return $this->setParameter('ios_badgeType', 'Increase')
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->setParameter('ios_badgeCount', $count);
    }

    /**
     * Set the iOS badge decrement count.
     *
     * @param int $count
     *
     * @return $this
     */
    public function decrementIosBadgeCount(int $count = 1)
    {
        return $this->setParameter('ios_badgeType', 'Increase')
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->setParameter('ios_badgeCount', -1 * $count);
    }

    /**
     * Set the iOS badge count.
     *
     * @param int $count
     *
     * @return $this
     */
    public function setIosBadgeCount(int $count)
    {
        return $this->setParameter('ios_badgeType', 'SetTo')
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->setParameter('ios_badgeCount', $count);
    }

    /**
     * Set the iOS Sound.
     *
     * @param string $soundUrl
     *
     * @return $this
     */
    public function setIosSound(string $soundUrl)
    {
        return $this->setParameter('ios_sound', $soundUrl);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the Android Sound.
     *
     * @param string $soundUrl
     *
     * @return $this
     */
    public function setAndroidSound(string $soundUrl)
    {
        return $this->setParameter('android_sound', $soundUrl);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the Windows Sound.
     *
     * @param string $soundUrl
     *
     * @return $this
     */
    public function setWindowsSound(string $soundUrl)
    {
        return $this->setParameter('wp_sound', $soundUrl)->setParameter('wp_wns_sound', $soundUrl);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the Sound for all Systems
     *
     * @param string $soundUrl
     *
     * @return $this
     */
    public function setSound(string $soundUrl)
    {
        return $this->setAndroidSound($soundUrl)
            ->setIosSound($soundUrl)
            ->setWindowsSound($soundUrl);
    }

    /**
     * Set the message icon.
     *
     * @param string $iconPath
     *
     * @return $this
     */
    public function icon(string $iconPath){
        return $this->setParameter('chrome_web_icon', $iconPath)
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->setParameter('chrome_icon', $iconPath)
            ->setParameter('adm_small_icon', $iconPath)
            ->setParameter('small_icon', $iconPath);
    }
}

1		<?php
2
3		namespace NotificationChannels\OneSignal\Traits\Categories;
4
5
6		trait AppearanceHelpers
7		{
8
9		/**
10		* Set the iOS badge increment count.
11		*
12		* @param int $count
13		*
14		* @return $this
15		*/
16	1	public function incrementIosBadgeCount(int $count = 1)
17		{
18	1	return $this->setParameter('ios_badgeType', 'Increase')
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19	1	->setParameter('ios_badgeCount', $count);
20		}
21
22		/**
23		* Set the iOS badge decrement count.
24		*
25		* @param int $count
26		*
27		* @return $this
28		*/
29	1	public function decrementIosBadgeCount(int $count = 1)
30		{
31	1	return $this->setParameter('ios_badgeType', 'Increase')
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32	1	->setParameter('ios_badgeCount', -1 * $count);
33		}
34
35		/**
36		* Set the iOS badge count.
37		*
38		* @param int $count
39		*
40		* @return $this
41		*/
42	1	public function setIosBadgeCount(int $count)
43		{
44	1	return $this->setParameter('ios_badgeType', 'SetTo')
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
45	1	->setParameter('ios_badgeCount', $count);
46		}
47
48		/**
49		* Set the iOS Sound.
50		*
51		* @param string $soundUrl
52		*
53		* @return $this
54		*/
55		public function setIosSound(string $soundUrl)
56		{
57		return $this->setParameter('ios_sound', $soundUrl);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
58		}
59
60		/**
61		* Set the Android Sound.
62		*
63		* @param string $soundUrl
64		*
65		* @return $this
66		*/
67		public function setAndroidSound(string $soundUrl)
68		{
69		return $this->setParameter('android_sound', $soundUrl);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
70		}
71
72		/**
73		* Set the Windows Sound.
74		*
75		* @param string $soundUrl
76		*
77		* @return $this
78		*/
79		public function setWindowsSound(string $soundUrl)
80		{
81		return $this->setParameter('wp_sound', $soundUrl)->setParameter('wp_wns_sound', $soundUrl);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
82		}
83
84		/**
85		* Set the Sound for all Systems
86		*
87		* @param string $soundUrl
88		*
89		* @return $this
90		*/
91		public function setSound(string $soundUrl)
92		{
93		return $this->setAndroidSound($soundUrl)
94		->setIosSound($soundUrl)
95		->setWindowsSound($soundUrl);
96		}
97
98		/**
99		* Set the message icon.
100		*
101		* @param string $iconPath
102		*
103		* @return $this
104		*/
105	6	public function icon(string $iconPath){
106	6	return $this->setParameter('chrome_web_icon', $iconPath)
		0 ignored issues – show Bug introduced 2018-03-14 06:42 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
107	6	->setParameter('chrome_icon', $iconPath)
108	6	->setParameter('adm_small_icon', $iconPath)
109	6	->setParameter('small_icon', $iconPath);
110		}
111		}

laravel-notification-channels / onesignal

GitHub Access Token became invalid

Pull Request — master (#58)

AppearanceHelpers A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

Duplication Side-by-Side

Filter issues like