OneSignalChannel::send() - Code Metrics - Inspection of "Add payload factory" - laravel-notification-channels/onesignal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#50)

by Tim

created 2018-02-28 00:29 UTC

OneSignalChannel::send() A

↳ Parent: OneSignalChannel

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	17
ccs	8
cts	8
cp	1
rs	9.4285
cc	3
eloc	8
nc	3
nop	2
crap	3

<?php

namespace NotificationChannels\OneSignal;

use Berkayk\OneSignal\OneSignalClient;
use Psr\Http\Message\ResponseInterface;
use Illuminate\Notifications\Notification;
use NotificationChannels\OneSignal\Exceptions\CouldNotSendNotification;

class OneSignalChannel
{
    /** @var OneSignalClient */
    protected $oneSignal;

    public function __construct(OneSignalClient $oneSignal)
    {
        $this->oneSignal = $oneSignal;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @return \Psr\Http\Message\ResponseInterface
     * @throws \NotificationChannels\OneSignal\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        if (! $userIds = $notifiable->routeNotificationFor('OneSignal')) {
            return;
        }

        /** @var ResponseInterface $response */
        $response = $this->oneSignal->sendNotificationCustom(
            $this->payload($notifiable, $notification, $userIds)
        );

        if ($response->getStatusCode() !== 200) {
            throw CouldNotSendNotification::serviceRespondedWithAnError($response);
        }

        return $response;
    }

    protected function payload($notifiable, $notification, $userIds)
    {
        return OneSignalPayloadFactory::make($notifiable, $notification, $userIds);
    }
}


1		<?php
2
3		namespace NotificationChannels\OneSignal;
4
5		use Berkayk\OneSignal\OneSignalClient;
6		use Psr\Http\Message\ResponseInterface;
7		use Illuminate\Notifications\Notification;
8		use NotificationChannels\OneSignal\Exceptions\CouldNotSendNotification;
9
10		class OneSignalChannel
11		{
12		/** @var OneSignalClient */
13		protected $oneSignal;
14
15	5	public function __construct(OneSignalClient $oneSignal)
16		{
17	5	$this->oneSignal = $oneSignal;
18	5	}
19
20		/**
21		* Send the given notification.
22		*
23		* @param mixed $notifiable
24		* @param \Illuminate\Notifications\Notification $notification
25		*
26		* @return \Psr\Http\Message\ResponseInterface
27		* @throws \NotificationChannels\OneSignal\Exceptions\CouldNotSendNotification
28		*/
29	5	public function send($notifiable, Notification $notification)
30		{
31	5	if (! $userIds = $notifiable->routeNotificationFor('OneSignal')) {
32	1	return;
33		}
34
35		/** @var ResponseInterface $response */
36	4	$response = $this->oneSignal->sendNotificationCustom(
37	4	$this->payload($notifiable, $notification, $userIds)
38		);
39
40	4	if ($response->getStatusCode() !== 200) {
41	1	throw CouldNotSendNotification::serviceRespondedWithAnError($response);
42		}
43
44	3	return $response;
45		}
46
47	4	protected function payload($notifiable, $notification, $userIds)
48		{
49	4	return OneSignalPayloadFactory::make($notifiable, $notification, $userIds);
50		}
51		}
52

laravel-notification-channels / onesignal

GitHub Access Token became invalid

Pull Request — master (#50)

OneSignalChannel::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like