OneSignalPayloadFactory::make() - Code Metrics - Inspection of "Add payload factory" - laravel-notification-channels/onesignal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#50)

by David

created 2018-02-28 19:32 UTC

OneSignalPayloadFactory::make() A

↳ Parent: OneSignalPayloadFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	12
ccs	6
cts	6
cp	1
rs	9.4285
cc	2
eloc	7
nc	2
nop	3
crap	2

<?php

namespace NotificationChannels\OneSignal;

use Illuminate\Notifications\Notification;

class OneSignalPayloadFactory
{
    /**
     * Make a one signal notification payload.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     * @param mixed $targeting
     *
     * @return array
     */
    public static function make($notifiable, Notification $notification, $targeting) : array
    {
        $payload = $notification->toOneSignal($notifiable)->toArray();


        if (static::isTargetingEmail($targeting)) {
            $payload['filters'] = collect([['field' => 'email', 'value' => $targeting['email']]]);
        } else {
            $payload['include_player_ids'] = collect($targeting);
        }

        return $payload;
    }

    /**
     * @param mixed $targeting
     *
     * @return bool
     */
    protected static function isTargetingEmail($targeting)
    {
        return is_array($targeting) && array_key_exists('email', $targeting);
    }
}


1		<?php
2
3		namespace NotificationChannels\OneSignal;
4
5		use Illuminate\Notifications\Notification;
6
7		class OneSignalPayloadFactory
8		{
9		/**
10		* Make a one signal notification payload.
11		*
12		* @param mixed $notifiable
13		* @param \Illuminate\Notifications\Notification $notification
14		* @param mixed $targeting
15		*
16		* @return array
17		*/
18	4	public static function make($notifiable, Notification $notification, $targeting) : array
19		{
20	4	$payload = $notification->toOneSignal($notifiable)->toArray();
		0 ignored issues – show Bug introduced 2018-02-28 19:34 UTC by Report Bug Copy Issue Report The method `toOneSignal()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
21
22	4	if (static::isTargetingEmail($targeting)) {
23	1	$payload['filters'] = collect([['field' => 'email', 'value' => $targeting['email']]]);
24		} else {
25	3	$payload['include_player_ids'] = collect($targeting);
26		}
27
28	4	return $payload;
29		}
30
31		/**
32		* @param mixed $targeting
33		*
34		* @return bool
35		*/
36	4	protected static function isTargetingEmail($targeting)
37		{
38	4	return is_array($targeting) && array_key_exists('email', $targeting);
39		}
40		}
41

laravel-notification-channels / onesignal

GitHub Access Token became invalid

Pull Request — master (#50)

OneSignalPayloadFactory::make() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like