ButtonHelpers - Code Metrics - Inspection of "[WIP]Refactor to Traits and add some little more P..." - laravel-notification-channels/onesignal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

by Lukas

created 2018-08-16 07:58 UTC

ButtonHelpers A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

36.36%

Importance

Changes

Metric	Value
wmc	4
lcom	0
cbo	3
dl	0
loc	63
ccs	4
cts	11
cp	0.3636
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	setWebButton()	4	1
A	setWebButtons()	8	1
A	setButton()	4	1
A	setButtons()	8	1

<?php

namespace NotificationChannels\OneSignal\Traits\Categories;

use NotificationChannels\OneSignal\OneSignalButton;
use NotificationChannels\OneSignal\OneSignalWebButton;

trait ButtonHelpers
{


    /**
     * Add a web button to the message.
     *
     * @param OneSignalWebButton $button
     *
     * @return $this
     */
    public function setWebButton(OneSignalWebButton $button)
    {
        return $this->setParameter('web_buttons', array_merge($this->getParameter('web_buttons', []), [$button->toArray()]));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Adds more than one web button to the message.
     *
     * @param array[OnSignalWebButton] $buttons

     *
     * @return $this
     */
    public function setWebButtons(array $buttons)
    {
        collect($buttons)->map(function ($button) {
            $this->setWebButton($button);
        });

        return $this;
    }



    /**
     * Add a native button to the message.
     *
     * @param OneSignalButton $button
     *
     * @return $this
     */
    public function setButton(OneSignalButton $button)
    {
        return $this->setParameter('buttons', array_merge($this->getParameter('buttons', []), [$button->toArray()]));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }


    /**
     * Adds more than one native button to the message.
     *
     * @param array $buttons
     *
     * @return $this
     */
    public function setButtons(array $buttons)
    {
        collect($buttons)->map(function ($button) {
            $this->setButton($button);
        });

        return $this;
    }
}


1		<?php
2
3		namespace NotificationChannels\OneSignal\Traits\Categories;
4
5		use NotificationChannels\OneSignal\OneSignalButton;
6		use NotificationChannels\OneSignal\OneSignalWebButton;
7
8		trait ButtonHelpers
9		{
10
11
12		/**
13		* Add a web button to the message.
14		*
15		* @param OneSignalWebButton $button
16		*
17		* @return $this
18		*/
19	2	public function setWebButton(OneSignalWebButton $button)
20		{
21	2	return $this->setParameter('web_buttons', array_merge($this->getParameter('web_buttons', []), [$button->toArray()]));
		0 ignored issues – show Bug introduced 2018-03-14 10:04 UTC by Report Bug Copy Issue Report It seems like `getParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-03-14 10:04 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22		}
23
24		/**
25		* Adds more than one web button to the message.
26		*
27		* @param array[OnSignalWebButton] $buttons
		0 ignored issues – show Documentation introduced 2018-03-14 10:04 UTC by Report Bug Copy Issue Report The doc-type `array[OnSignalWebButton]` could not be parsed: Expected "]" at position 2, but found "OnSignalWebButton". (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
28		*
29		* @return $this
30		*/
31		public function setWebButtons(array $buttons)
32		{
33		collect($buttons)->map(function ($button) {
34		$this->setWebButton($button);
35		});
36
37		return $this;
38		}
39
40
41
42		/**
43		* Add a native button to the message.
44		*
45		* @param OneSignalButton $button
46		*
47		* @return $this
48		*/
49	1	public function setButton(OneSignalButton $button)
50		{
51	1	return $this->setParameter('buttons', array_merge($this->getParameter('buttons', []), [$button->toArray()]));
		0 ignored issues – show Bug introduced 2018-03-14 10:04 UTC by Report Bug Copy Issue Report It seems like `getParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2018-03-14 10:04 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
52		}
53
54
55		/**
56		* Adds more than one native button to the message.
57		*
58		* @param array $buttons
59		*
60		* @return $this
61		*/
62		public function setButtons(array $buttons)
63		{
64		collect($buttons)->map(function ($button) {
65		$this->setButton($button);
66		});
67
68		return $this;
69		}
70		}
71

laravel-notification-channels / onesignal

GitHub Access Token became invalid

Pull Request — master (#58)

ButtonHelpers A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like