GroupingHelpers - Code Metrics - Inspection of "[WIP]Refactor to Traits and add some little more P..." - laravel-notification-channels/onesignal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

by Lukas

created 2018-03-14 06:48 UTC

GroupingHelpers A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	3
c	0
b	0
f	0
lcom	0
cbo	0
dl	0
loc	41
ccs	0
cts	9
cp	0
rs	10

3 Methods

Rating	Name	Size	Complexity
A	setAndroidGroup()	5	1
A	setAmazonGroup()	5	1
A	setGroup()	5	1

<?php

namespace NotificationChannels\OneSignal\Traits\Categories;

trait GroupingHelpers
{
    /**
     * Set the Android Grouping Parameters.
     * @param string $group
     * @param array  $groupMessage
     *
     * @return $this
     */
    public function setAndroidGroup(string $group, array $groupMessage)
    {
        return $this->setParameter('android_group', $group)
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->setParameter('android_group_message', $groupMessage);
    }

    /**
     * Set the Amazon (FireOS) Grouping Parameters.
     * @param string $group
     * @param array  $groupMessage
     *
     * @return $this
     */
    public function setAmazonGroup(string $group, array $groupMessage)
    {
        return $this->setParameter('adm_group', $group)
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->setParameter('adm_group_message', $groupMessage);
    }

    /**
     * Set the Grouping Parameters for all available Systems (currently Android and Amazon (FireOs)).
     * @param string $group
     * @param array  $groupMessage
     *
     * @return $this
     */
    public function setGroup(string $group, array $groupMessage)
    {
        return $this->setAndroidGroup($group, $groupMessage)
            ->setAmazonGroup($group, $groupMessage);
    }
}


1			<?php
2
3			namespace NotificationChannels\OneSignal\Traits\Categories;
4
5			trait GroupingHelpers
6			{
7			/**
8			* Set the Android Grouping Parameters.
9			* @param string $group
10			* @param array $groupMessage
11			*
12			* @return $this
13			*/
14			public function setAndroidGroup(string $group, array $groupMessage)
15			{
16			return $this->setParameter('android_group', $group)
			0 ignored issues – show Bug introduced 2018-03-14 06:23 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17			->setParameter('android_group_message', $groupMessage);
18			}
19
20			/**
21			* Set the Amazon (FireOS) Grouping Parameters.
22			* @param string $group
23			* @param array $groupMessage
24			*
25			* @return $this
26			*/
27			public function setAmazonGroup(string $group, array $groupMessage)
28			{
29			return $this->setParameter('adm_group', $group)
			0 ignored issues – show Bug introduced 2018-03-14 06:23 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30			->setParameter('adm_group_message', $groupMessage);
31			}
32
33			/**
34			* Set the Grouping Parameters for all available Systems (currently Android and Amazon (FireOs)).
35			* @param string $group
36			* @param array $groupMessage
37			*
38			* @return $this
39			*/
40			public function setGroup(string $group, array $groupMessage)
41			{
42			return $this->setAndroidGroup($group, $groupMessage)
43			->setAmazonGroup($group, $groupMessage);
44			}
45			}
46

laravel-notification-channels / onesignal

GitHub Access Token became invalid

Pull Request — master (#58)

GroupingHelpers A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like