AttachmentHelpers - Code Metrics - Inspection of "[WIP]Refactor to Traits and add some little more P..." - laravel-notification-channels/onesignal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

by Lukas

created 2018-03-14 06:48 UTC

AttachmentHelpers A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

78.95%

Importance

Changes

Metric	Value
wmc	8
c	0
b	0
f	0
lcom	1
cbo	0
dl	0
loc	99
ccs	15
cts	19
cp	0.7895
rs	10

8 Methods

Rating	Name	Size	Complexity
A	setImageAttachments()	7	1
A	setIosAttachment()	4	1
A	setIosAttachments()	4	1
A	setAndroidBigPicture()	4	1
A	setAmazonBigPicture()	4	1
A	setChromeBigPicture()	4	1
A	setData()	4	1
A	setUrl()	4	1

<?php

namespace NotificationChannels\OneSignal\Traits\Categories;

trait AttachmentHelpers
{
    /**
     * Set an Image only for iOS.
     *
     * @param string $imageUrl
     *
     * @return $this
     */
    public function setIosAttachment(string $imageUrl)
    {
        return $this->setParameter('ios_attachments', ['id1' => $imageUrl]);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set multiple Images only for iOS.
     *
     * @param array $images
     *
     * @return $this
     */
    public function setIosAttachments(array $images)
    {
        return $this->setParameter('ios_attachments', $images);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the Big Picture Image only for Android.
     *
     * @param string $imageUrl
     *
     * @return $this
     */
    public function setAndroidBigPicture(string $imageUrl)
    {
        return $this->setParameter('big_picture', $imageUrl);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the Big Picture Image only for FireOS (Amazon).
     *
     * @param string $imageUrl
     *
     * @return $this
     */
    public function setAmazonBigPicture(string $imageUrl)
    {
        return $this->setParameter('adm_big_picture', $imageUrl);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the Big Picture Image only for Chrome.
     *
     * @param string $imageUrl
     *
     * @return $this
     */
    public function setChromeBigPicture(string $imageUrl)
    {
        return $this->setParameter('chrome_big_picture', $imageUrl);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the additional Data for all Platforms.
     * @param array $data
     *
     * @return $this
     */
    public function setData(array $data)
    {
        return $this->setParameter('data', $data);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set the additional URL for all Platforms.
     * @param string $url
     *
     * @return $this
     */
    public function setUrl(string $url)
    {
        return $this->setParameter('url', $url);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Set an image to all possible attachment variables.
     *
     * @param string $imageUrl
     *
     * @return $this
     */
    public function setImageAttachments(string $imageUrl)
    {
        return $this->setIosAttachment($imageUrl)
            ->setAndroidBigPicture($imageUrl)
            ->setAmazonBigPicture($imageUrl)
            ->setChromeBigPicture($imageUrl);
    }
}


1		<?php
2
3		namespace NotificationChannels\OneSignal\Traits\Categories;
4
5		trait AttachmentHelpers
6		{
7		/**
8		* Set an Image only for iOS.
9		*
10		* @param string $imageUrl
11		*
12		* @return $this
13		*/
14	1	public function setIosAttachment(string $imageUrl)
15		{
16	1	return $this->setParameter('ios_attachments', ['id1' => $imageUrl]);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17		}
18
19		/**
20		* Set multiple Images only for iOS.
21		*
22		* @param array $images
23		*
24		* @return $this
25		*/
26		public function setIosAttachments(array $images)
27		{
28		return $this->setParameter('ios_attachments', $images);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29		}
30
31		/**
32		* Set the Big Picture Image only for Android.
33		*
34		* @param string $imageUrl
35		*
36		* @return $this
37		*/
38	1	public function setAndroidBigPicture(string $imageUrl)
39		{
40	1	return $this->setParameter('big_picture', $imageUrl);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41		}
42
43		/**
44		* Set the Big Picture Image only for FireOS (Amazon).
45		*
46		* @param string $imageUrl
47		*
48		* @return $this
49		*/
50	1	public function setAmazonBigPicture(string $imageUrl)
51		{
52	1	return $this->setParameter('adm_big_picture', $imageUrl);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
53		}
54
55		/**
56		* Set the Big Picture Image only for Chrome.
57		*
58		* @param string $imageUrl
59		*
60		* @return $this
61		*/
62	1	public function setChromeBigPicture(string $imageUrl)
63		{
64	1	return $this->setParameter('chrome_big_picture', $imageUrl);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
65		}
66
67		/**
68		* Set the additional Data for all Platforms.
69		* @param array $data
70		*
71		* @return $this
72		*/
73		public function setData(array $data)
74		{
75		return $this->setParameter('data', $data);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
76		}
77
78		/**
79		* Set the additional URL for all Platforms.
80		* @param string $url
81		*
82		* @return $this
83		*/
84	6	public function setUrl(string $url)
85		{
86	6	return $this->setParameter('url', $url);
		0 ignored issues – show Bug introduced 2018-03-14 06:13 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
87		}
88
89		/**
90		* Set an image to all possible attachment variables.
91		*
92		* @param string $imageUrl
93		*
94		* @return $this
95		*/
96	1	public function setImageAttachments(string $imageUrl)
97		{
98	1	return $this->setIosAttachment($imageUrl)
99	1	->setAndroidBigPicture($imageUrl)
100	1	->setAmazonBigPicture($imageUrl)
101	1	->setChromeBigPicture($imageUrl);
102		}
103		}
104

laravel-notification-channels / onesignal

GitHub Access Token became invalid

Pull Request — master (#58)

AttachmentHelpers A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

Duplication Side-by-Side

Filter issues like