MessagebirdChannel::send() - Code Metrics - Inspection of "Dispatching response" - laravel-notification-channels/messagebird - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#27)

unknown

created 2020-03-10 12:17 UTC

MessagebirdChannel::send() A

↳ Parent: MessagebirdChannel

Complexity

Conditions	4
Paths	12

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	29
ccs	0
cts	16
cp	0
rs	9.456
c	0
b	0
f	0
cc	4
nc	12
nop	2
crap	20

<?php

namespace NotificationChannels\Messagebird;

use Illuminate\Notifications\Notification;
use Illuminate\Contracts\Events\Dispatcher;
use Illuminate\Notifications\Events\NotificationFailed;
use NotificationChannels\Messagebird\Exceptions\CouldNotSendNotification;

class MessagebirdChannel
{
    /** @var \NotificationChannels\Messagebird\MessagebirdClient */
    protected $client;
    private $_dispatcher;

    public function __construct(MessagebirdClient $client, Dispatcher $dispatcher)
    {
        $this->client = $client;
        $this->_dispatcher = $dispatcher;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @return array
     * @throws \NotificationChannels\MessageBird\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        $message = $notification->toMessagebird($notifiable);


        $response = [];

        if (is_string($message)) {
            $message = MessagebirdMessage::create($message);
        }

        if ($to = $notifiable->routeNotificationFor('messagebird')) {
            $message->setRecipients($to);
        }

        try {
            $response = $this->client->send($message);

            $this->_dispatcher->dispatch('messagebird-sms', [$notifiable, $notification, $response]);
        } catch (CouldNotSendNotification $e) {
            new NotificationFailed(
                $notifiable,
                $notification,
                'messagebird-sms',
                $e->getMessage()
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
        }

        return $response;
    }
}


1			<?php
2
3			namespace NotificationChannels\Messagebird;
4
5			use Illuminate\Notifications\Notification;
6			use Illuminate\Contracts\Events\Dispatcher;
7			use Illuminate\Notifications\Events\NotificationFailed;
8			use NotificationChannels\Messagebird\Exceptions\CouldNotSendNotification;
9
10			class MessagebirdChannel
11			{
12			/** @var \NotificationChannels\Messagebird\MessagebirdClient */
13			protected $client;
14			private $_dispatcher;
15
16			public function __construct(MessagebirdClient $client, Dispatcher $dispatcher)
17			{
18			$this->client = $client;
19			$this->_dispatcher = $dispatcher;
20			}
21
22			/**
23			* Send the given notification.
24			*
25			* @param mixed $notifiable
26			* @param \Illuminate\Notifications\Notification $notification
27			*
28			* @return array
29			* @throws \NotificationChannels\MessageBird\Exceptions\CouldNotSendNotification
30			*/
31			public function send($notifiable, Notification $notification)
32			{
33			$message = $notification->toMessagebird($notifiable);
			0 ignored issues – show Bug introduced 2017-11-23 17:41 UTC by Report Bug Copy Issue Report The method `toMessagebird()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
34
35			$response = [];
36
37			if (is_string($message)) {
38			$message = MessagebirdMessage::create($message);
39			}
40
41			if ($to = $notifiable->routeNotificationFor('messagebird')) {
42			$message->setRecipients($to);
43			}
44
45			try {
46			$response = $this->client->send($message);
47
48			$this->_dispatcher->dispatch('messagebird-sms', [$notifiable, $notification, $response]);
49			} catch (CouldNotSendNotification $e) {
50			new NotificationFailed(
51			$notifiable,
52			$notification,
53			'messagebird-sms',
54			$e->getMessage()
			0 ignored issues – show Documentation introduced 2020-03-10 12:19 UTC by Report Bug Copy Issue Report `$e->getMessage()` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
55			);
56			}
57
58			return $response;
59			}
60			}
61

laravel-notification-channels / messagebird

GitHub Access Token became invalid

Pull Request — master (#27)

MessagebirdChannel::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like