MessagebirdChannel::send() - Code Metrics - Inspection of "Dispatching response" - laravel-notification-channels/messagebird - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#28)

unknown

created 2020-03-10 13:42 UTC

MessagebirdChannel::send() A

↳ Parent: MessagebirdChannel

Complexity

Conditions	5
Paths	16

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	6.4704

Importance

Changes

Metric	Value
dl	0
loc	33
ccs	11
cts	18
cp	0.6111
rs	9.0808
c	0
b	0
f	0
cc	5
nc	16
nop	2
crap	6.4704

<?php

namespace NotificationChannels\Messagebird;

use Illuminate\Contracts\Events\Dispatcher;
use Illuminate\Notifications\Events\NotificationFailed;
use Illuminate\Notifications\Notification;
use NotificationChannels\Messagebird\Exceptions\CouldNotSendNotification;

class MessagebirdChannel
{
    /** @var \NotificationChannels\Messagebird\MessagebirdClient */
    protected $client;
    private $dispatcher;

    public function __construct(MessagebirdClient $client, Dispatcher $dispatcher = null)
    {
        $this->client = $client;
        $this->dispatcher = $dispatcher;
    }

    /**
     * Send the given notification.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @return array
     * @throws \NotificationChannels\MessageBird\Exceptions\CouldNotSendNotification
     */
    public function send($notifiable, Notification $notification)
    {
        $message = $notification->toMessagebird($notifiable);


        $response = [];

        if (is_string($message)) {
            $message = MessagebirdMessage::create($message);
        }

        if ($to = $notifiable->routeNotificationFor('messagebird')) {
            $message->setRecipients($to);
        }

        try {
            $response = $this->client->send($message);

            if ($this->dispatcher !== null) {
                $this->dispatcher->dispatch('messagebird-sms', [$notifiable, $notification, $response]);
            }
        } catch (CouldNotSendNotification $e) {
            $this->dispatcher->dispatch(
                new NotificationFailed(
                    $notifiable,
                    $notification,
                    'messagebird-sms',
                    $e->getMessage()
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            )
            );
        }

        return $response;
    }
}


1		<?php
2
3		namespace NotificationChannels\Messagebird;
4
5		use Illuminate\Contracts\Events\Dispatcher;
6		use Illuminate\Notifications\Events\NotificationFailed;
7		use Illuminate\Notifications\Notification;
8		use NotificationChannels\Messagebird\Exceptions\CouldNotSendNotification;
9
10		class MessagebirdChannel
11		{
12		/** @var \NotificationChannels\Messagebird\MessagebirdClient */
13		protected $client;
14		private $dispatcher;
15
16	3	public function __construct(MessagebirdClient $client, Dispatcher $dispatcher = null)
17		{
18	3	$this->client = $client;
19	3	$this->dispatcher = $dispatcher;
20	3	}
21
22		/**
23		* Send the given notification.
24		*
25		* @param mixed $notifiable
26		* @param \Illuminate\Notifications\Notification $notification
27		*
28		* @return array
29		* @throws \NotificationChannels\MessageBird\Exceptions\CouldNotSendNotification
30		*/
31	2	public function send($notifiable, Notification $notification)
32		{
33	2	$message = $notification->toMessagebird($notifiable);
		0 ignored issues – show Bug introduced 2017-11-23 17:41 UTC by Report Bug Copy Issue Report The method `toMessagebird()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
34
35	2	$response = [];
36
37	2	if (is_string($message)) {
38	1	$message = MessagebirdMessage::create($message);
39		}
40
41	2	if ($to = $notifiable->routeNotificationFor('messagebird')) {
42	2	$message->setRecipients($to);
43		}
44
45		try {
46	2	$response = $this->client->send($message);
47
48	2	if ($this->dispatcher !== null) {
49	2	$this->dispatcher->dispatch('messagebird-sms', [$notifiable, $notification, $response]);
50		}
51		} catch (CouldNotSendNotification $e) {
52		$this->dispatcher->dispatch(
53		new NotificationFailed(
54		$notifiable,
55		$notification,
56		'messagebird-sms',
57		$e->getMessage()
		0 ignored issues – show Documentation introduced 2020-03-10 12:19 UTC by Report Bug Copy Issue Report `$e->getMessage()` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
58		)
59		);
60		}
61
62	2	return $response;
63		}
64		}
65

laravel-notification-channels / messagebird

GitHub Access Token became invalid

Pull Request — master (#28)

MessagebirdChannel::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like