Packet::toJson() - Code Metrics - Inspection of "Added the ability to send GCM messages to iOS" - laravel-notification-channels/gcm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

unknown

created 2016-12-01 19:45 UTC

Packet::toJson() F

↳ Parent: Packet

Complexity

Conditions	9
Paths	256

Size

Total Lines	30
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	90

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	30
ccs	0
cts	29
cp	0
rs	3
c	1
b	0
f	0
cc	9
eloc	19
nc	256
nop	0
crap	90

<?php

namespace NotificationChannels\Gcm;

use ZendService\Google\Gcm\Message;
use Zend\Json\Json;

class Packet extends Message
{
    /**
     * @var array
     */
    protected $notification;

    /**
     * Set the notification
     *
     * @param array $ids
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return Message
     */
    public function setNotification($notification)
    {
        $this->notification = $notification;
        return $this;
    }

    /**
     * To JSON
     * Utility method to put the JSON into the
     * GCM proper format for sending the message.
     *
     * @return string
     */
    public function toJson()
    {
        $json = array();
        if ($this->registrationIds) {

            $json['registration_ids'] = $this->registrationIds;
        }
        if ($this->collapseKey) {
            $json['collapse_key'] = $this->collapseKey;
        }
        if ($this->data) {

            $json['data'] = $this->data;
        }
        if ($this->notification) {

            $json['notification'] = $this->notification;
        }
        if ($this->delayWhileIdle) {
            $json['delay_while_idle'] = $this->delayWhileIdle;
        }
        if ($this->timeToLive != 2419200) {
            $json['time_to_live'] = $this->timeToLive;
        }
        if ($this->restrictedPackageName) {
            $json['restricted_package_name'] = $this->restrictedPackageName;
        }
        if ($this->dryRun) {
            $json['dry_run'] = $this->dryRun;
        }

        return Json::encode($json);
    }
}


1			<?php
2
3			namespace NotificationChannels\Gcm;
4
5			use ZendService\Google\Gcm\Message;
6			use Zend\Json\Json;
7
8			class Packet extends Message
9			{
10			/**
11			* @var array
12			*/
13			protected $notification;
14
15			/**
16			* Set the notification
17			*
18			* @param array $ids
			0 ignored issues – show Bug introduced 2016-12-01 19:51 UTC by Report Bug Copy Issue Report There is no parameter named `$ids`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
19			* @return Message
20			*/
21			public function setNotification($notification)
22			{
23			$this->notification = $notification;
24			return $this;
25			}
26
27			/**
28			* To JSON
29			* Utility method to put the JSON into the
30			* GCM proper format for sending the message.
31			*
32			* @return string
33			*/
34			public function toJson()
35			{
36			$json = array();
37			if ($this->registrationIds) {
			0 ignored issues – show Bug Best Practice introduced 2016-12-01 19:51 UTC by Report Bug Copy Issue Report The expression `$this->registrationIds` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
38			$json['registration_ids'] = $this->registrationIds;
39			}
40			if ($this->collapseKey) {
41			$json['collapse_key'] = $this->collapseKey;
42			}
43			if ($this->data) {
			0 ignored issues – show Bug Best Practice introduced 2016-12-01 19:51 UTC by Report Bug Copy Issue Report The expression `$this->data` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
44			$json['data'] = $this->data;
45			}
46			if ($this->notification) {
			0 ignored issues – show Bug Best Practice introduced 2016-12-01 19:51 UTC by Report Bug Copy Issue Report The expression `$this->notification` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
47			$json['notification'] = $this->notification;
48			}
49			if ($this->delayWhileIdle) {
50			$json['delay_while_idle'] = $this->delayWhileIdle;
51			}
52			if ($this->timeToLive != 2419200) {
53			$json['time_to_live'] = $this->timeToLive;
54			}
55			if ($this->restrictedPackageName) {
56			$json['restricted_package_name'] = $this->restrictedPackageName;
57			}
58			if ($this->dryRun) {
59			$json['dry_run'] = $this->dryRun;
60			}
61
62			return Json::encode($json);
63			}
64			}
65

laravel-notification-channels / gcm

Pull Request — master (#9)

Packet::toJson() F

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like