GcmChannel::send() - Code Metrics - Inspection of "Added the ability to send GCM messages to iOS" - laravel-notification-channels/gcm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

unknown

created 2016-12-01 19:45 UTC

GcmChannel::send() B

↳ Parent: GcmChannel

Complexity

Conditions	5
Paths	5

Size

Total Lines	24
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	14.1113

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	4
cts	14
cp	0.2857
rs	8.5125
c	0
b	0
f	0
cc	5
eloc	14
nc	5
nop	2
crap	14.1113

<?php

namespace NotificationChannels\Gcm;

use Exception;
use Illuminate\Events\Dispatcher;
use Illuminate\Notifications\Events\NotificationFailed;
use Illuminate\Notifications\Notification;
use NotificationChannels\Gcm\Exceptions\SendingFailed;
use ZendService\Google\Gcm\Client;

class GcmChannel
{
    /** @var Client */
    protected $client;

    /** @var Dispatcher */
    protected $events;

    /**
     * @param Client $client
     * @param Dispatcher $events
     */
    public function __construct(Client $client, Dispatcher $events)
    {
        $this->client = $client;
        $this->events = $events;
    }

    /**
     * Send the notification to Google Cloud Messaging.
     *
     * @param mixed $notifiable
     * @param Notification $notification
     * @return void
     *
     * @throws Exceptions\SendingFailed
     */
    public function send($notifiable, Notification $notification)
    {
        $tokens = (array) $notifiable->routeNotificationFor('gcm');
        if (! $tokens) {

            return;
        }

        $message = $notification->toGcm($notifiable);
        if (! $message) {
            return;
        }

        $packet = $this->getPacket($tokens, $message);

        try {
            $response = $this->client->send($packet);
        } catch (Exception $exception) {
            throw SendingFailed::create($exception);
        }

        if (! $response->getFailureCount() == 0) {
            $this->handleFailedNotifications($notifiable, $notification, $response);
        }
    }

    /**
     * @param $tokens
     * @param $message
     *
     * @return \NotificationChannels\Gcm\Packet
     */
    protected function getPacket($tokens, $message)
    {
        $packet = new Packet();

        $packet->setRegistrationIds($tokens);
        $packet->setCollapseKey(str_slug($message->title));
        $packet->setData([
                'title' => $message->title,
                'message' => $message->message,
            ] + $message->data);
        $packet->setNotification([
                'title' => $message->title,
                'message' => $message->message,
            ] + $message->data);

        return $packet;
    }

    /**
     * @param $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     * @param $response
     */
    protected function handleFailedNotifications($notifiable, Notification $notification, $response)
    {
        $results = $response->getResults();

        foreach ($results as $token => $result) {
            if (! isset($result['error'])) {
                continue;
            }

            $this->events->fire(
                new NotificationFailed($notifiable, $notification, $this, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    'token' => $token,
                    'error' => $result['error'],
                ])
            );
        }
    }
}


1		<?php
2
3		namespace NotificationChannels\Gcm;
4
5		use Exception;
6		use Illuminate\Events\Dispatcher;
7		use Illuminate\Notifications\Events\NotificationFailed;
8		use Illuminate\Notifications\Notification;
9		use NotificationChannels\Gcm\Exceptions\SendingFailed;
10		use ZendService\Google\Gcm\Client;
11
12		class GcmChannel
13		{
14		/** @var Client */
15		protected $client;
16
17		/** @var Dispatcher */
18		protected $events;
19
20		/**
21		* @param Client $client
22		* @param Dispatcher $events
23		*/
24	1	public function __construct(Client $client, Dispatcher $events)
25		{
26	1	$this->client = $client;
27	1	$this->events = $events;
28	1	}
29
30		/**
31		* Send the notification to Google Cloud Messaging.
32		*
33		* @param mixed $notifiable
34		* @param Notification $notification
35		* @return void
36		*
37		* @throws Exceptions\SendingFailed
38		*/
39	1	public function send($notifiable, Notification $notification)
40		{
41	1	$tokens = (array) $notifiable->routeNotificationFor('gcm');
42	1	if (! $tokens) {
		0 ignored issues – show Bug Best Practice introduced 2016-08-27 08:52 UTC by Report Bug Copy Issue Report The expression `$tokens` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
43	1	return;
44		}
45
46		$message = $notification->toGcm($notifiable);
47		if (! $message) {
48		return;
49		}
50
51		$packet = $this->getPacket($tokens, $message);
52
53		try {
54		$response = $this->client->send($packet);
55		} catch (Exception $exception) {
56		throw SendingFailed::create($exception);
57		}
58
59		if (! $response->getFailureCount() == 0) {
60		$this->handleFailedNotifications($notifiable, $notification, $response);
61		}
62		}
63
64		/**
65		* @param $tokens
66		* @param $message
67		*
68		* @return \NotificationChannels\Gcm\Packet
69		*/
70		protected function getPacket($tokens, $message)
71		{
72		$packet = new Packet();
73
74		$packet->setRegistrationIds($tokens);
75		$packet->setCollapseKey(str_slug($message->title));
76		$packet->setData([
77		'title' => $message->title,
78		'message' => $message->message,
79		] + $message->data);
80		$packet->setNotification([
81		'title' => $message->title,
82		'message' => $message->message,
83		] + $message->data);
84
85		return $packet;
86		}
87
88		/**
89		* @param $notifiable
90		* @param \Illuminate\Notifications\Notification $notification
91		* @param $response
92		*/
93		protected function handleFailedNotifications($notifiable, Notification $notification, $response)
94		{
95		$results = $response->getResults();
96
97		foreach ($results as $token => $result) {
98		if (! isset($result['error'])) {
99		continue;
100		}
101
102		$this->events->fire(
103		new NotificationFailed($notifiable, $notification, $this, [
		0 ignored issues – show Documentation introduced 2016-08-27 08:52 UTC by Report Bug Copy Issue Report `$this` is of type `this<NotificationChannels\Gcm\GcmChannel>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
104		'token' => $token,
105		'error' => $result['error'],
106		])
107		);
108		}
109		}
110		}
111

laravel-notification-channels / gcm

Pull Request — master (#9)

GcmChannel::send() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like