Packet::toJson() - Code Metrics - Inspection of "Update zendservice-google-gcm (#20)" - laravel-notification-channels/gcm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 58c117...c459c0 )

by Barry vd.

created 2017-05-06 18:25 UTC

Packet::toJson() F

↳ Parent: Packet

Complexity

Conditions	9
Paths	256

Size

Total Lines	30
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	11.107

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	30
ccs	19
cts	27
cp	0.7037
rs	3
c	1
b	0
f	0
cc	9
eloc	19
nc	256
nop	0
crap	11.107

<?php

namespace NotificationChannels\Gcm;

use Zend\Json\Json;
use ZendService\Google\Gcm\Message;

class Packet extends Message
{
    /**
     * @var array
     */
    protected $notification;

    /**
     * Set the notification.
     *
     * @param array $notification
     * @return Message
     */
    public function setNotification(array $notification)
    {
        $this->notification = $notification;

        return $this;
    }

    /**
     * To JSON
     * Utility method to put the JSON into the
     * GCM proper format for sending the message.
     *
     * @return string
     */
    public function toJson()
    {
        $json = [];
        if ($this->registrationIds) {

            $json['registration_ids'] = $this->registrationIds;
        }
        if ($this->collapseKey) {
            $json['collapse_key'] = $this->collapseKey;
        }
        if ($this->data) {

            $json['data'] = $this->data;
        }
        if ($this->notification) {

            $json['notification'] = $this->notification;
        }
        if ($this->delayWhileIdle) {
            $json['delay_while_idle'] = $this->delayWhileIdle;
        }
        if ($this->timeToLive != 2419200) {
            $json['time_to_live'] = $this->timeToLive;
        }
        if ($this->restrictedPackageName) {
            $json['restricted_package_name'] = $this->restrictedPackageName;
        }
        if ($this->dryRun) {
            $json['dry_run'] = $this->dryRun;
        }

        return Json::encode($json);
    }
}


1		<?php
2
3		namespace NotificationChannels\Gcm;
4
5		use Zend\Json\Json;
6		use ZendService\Google\Gcm\Message;
7
8		class Packet extends Message
9		{
10		/**
11		* @var array
12		*/
13		protected $notification;
14
15		/**
16		* Set the notification.
17		*
18		* @param array $notification
19		* @return Message
20		*/
21	1	public function setNotification(array $notification)
22		{
23	1	$this->notification = $notification;
24
25	1	return $this;
26		}
27
28		/**
29		* To JSON
30		* Utility method to put the JSON into the
31		* GCM proper format for sending the message.
32		*
33		* @return string
34		*/
35	1	public function toJson()
36		{
37	1	$json = [];
38	1	if ($this->registrationIds) {
		0 ignored issues – show Bug Best Practice introduced 2016-12-01 19:51 UTC by Report Bug Copy Issue Report The expression `$this->registrationIds` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
39	1	$json['registration_ids'] = $this->registrationIds;
40	1	}
41	1	if ($this->collapseKey) {
42	1	$json['collapse_key'] = $this->collapseKey;
43	1	}
44	1	if ($this->data) {
		0 ignored issues – show Bug Best Practice introduced 2016-12-01 19:51 UTC by Report Bug Copy Issue Report The expression `$this->data` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
45	1	$json['data'] = $this->data;
46	1	}
47	1	if ($this->notification) {
		0 ignored issues – show Bug Best Practice introduced 2016-12-01 19:51 UTC by Report Bug Copy Issue Report The expression `$this->notification` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
48	1	$json['notification'] = $this->notification;
49	1	}
50	1	if ($this->delayWhileIdle) {
51		$json['delay_while_idle'] = $this->delayWhileIdle;
52		}
53	1	if ($this->timeToLive != 2419200) {
54		$json['time_to_live'] = $this->timeToLive;
55		}
56	1	if ($this->restrictedPackageName) {
57		$json['restricted_package_name'] = $this->restrictedPackageName;
58		}
59	1	if ($this->dryRun) {
60		$json['dry_run'] = $this->dryRun;
61		}
62
63	1	return Json::encode($json);
64		}
65		}
66

laravel-notification-channels / gcm

Push — master ( 58c117...c459c0 )

Packet::toJson() F

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like