FacebookPosterChannel::send() - Code Metrics - Inspection of "Decouple post and channel" - laravel-notification-channels/facebook-poster - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#36)

by Dwight

created 2019-10-04 01:08 UTC

FacebookPosterChannel::send() A

↳ Parent: FacebookPosterChannel

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3.0123

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	8
cts	9
cp	0.8889
rs	9.7333
c	0
b	0
f	0
cc	3
nc	4
nop	2
crap	3.0123

<?php

namespace NotificationChannels\FacebookPoster;

use Facebook\Facebook;
use Illuminate\Notifications\Notification;

class FacebookPosterChannel
{
    /**
     * The Facebook client.
     *
     * @var \Facebook\Facebook
     */
    protected $facebook;

    /**
     * Create a new channel instance.
     *
     * @param  \Facebook\Facebook  $facebook
     */
    public function __construct(Facebook $facebook)
    {
        $this->facebook = $facebook;
    }

    /**
     * Send the given notification.
     *
     * @param  mixed  $notifiable
     * @param  \Illuminate\Notifications\Notification $notification
     */
    public function send($notifiable, Notification $notification)
    {
        if ($facebookSettings = $notifiable->routeNotificationFor('facebookPoster')) {
            $this->switchSettings($facebookSettings);
        }

        $post = $notification->toFacebookPoster($notifiable);


        $body = $post->getBody();

        if ($media = $post->getMedia()) {
            $body['source'] = $this->facebook->{$media::API_METHOD}($media->getPath());
        }

        $this->facebook->post($post->getEndpoint(), $body);
    }

    /**
     * Use per user settings instead of default ones.
     *
     * @param  array  $config
     * @return void
     */
    protected function switchSettings(array $config)
    {
        $this->facebook = new Facebook($config);
    }
}


1		<?php
2
3		namespace NotificationChannels\FacebookPoster;
4
5		use Facebook\Facebook;
6		use Illuminate\Notifications\Notification;
7
8		class FacebookPosterChannel
9		{
10		/**
11		* The Facebook client.
12		*
13		* @var \Facebook\Facebook
14		*/
15		protected $facebook;
16
17		/**
18		* Create a new channel instance.
19		*
20		* @param \Facebook\Facebook $facebook
21		*/
22	4	public function __construct(Facebook $facebook)
23		{
24	4	$this->facebook = $facebook;
25	4	}
26
27		/**
28		* Send the given notification.
29		*
30		* @param mixed $notifiable
31		* @param \Illuminate\Notifications\Notification $notification
32		*/
33	4	public function send($notifiable, Notification $notification)
34		{
35	4	if ($facebookSettings = $notifiable->routeNotificationFor('facebookPoster')) {
36		$this->switchSettings($facebookSettings);
37		}
38
39	4	$post = $notification->toFacebookPoster($notifiable);
		0 ignored issues – show Bug introduced 2019-10-04 01:09 UTC by Report Bug Copy Issue Report The method `toFacebookPoster()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
40
41	4	$body = $post->getBody();
42
43	4	if ($media = $post->getMedia()) {
44	2	$body['source'] = $this->facebook->{$media::API_METHOD}($media->getPath());
45		}
46
47	4	$this->facebook->post($post->getEndpoint(), $body);
48	4	}
49
50		/**
51		* Use per user settings instead of default ones.
52		*
53		* @param array $config
54		* @return void
55		*/
56		protected function switchSettings(array $config)
57		{
58		$this->facebook = new Facebook($config);
59		}
60		}
61

laravel-notification-channels / facebook-poster

GitHub Access Token became invalid

Pull Request — master (#36)

FacebookPosterChannel::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like