BroadcastChannel::__construct() - Code Metrics - Inspection of "Add notification failed event" - laravel-notification-channels/backport - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 88d547...129b2c )

by Marcel

created 2016-08-18 13:51 UTC

BroadcastChannel::__construct() A

↳ Parent: BroadcastChannel

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace Illuminate\Notifications\Channels;

use RuntimeException;
use Illuminate\Notifications\Notification;
use Illuminate\Contracts\Events\Dispatcher;
use Illuminate\Notifications\Events\BroadcastNotificationCreated;

class BroadcastChannel
{
    /**
     * The event dispatcher.
     *
     * @var \Illuminate\Contracts\Events\Dispatcher
     */
    protected $events;

    /**
     * Create a new database channel.
     *
     * @param  \Illuminate\Contracts\Events\Dispatcher  $events
     * @return void

     */
    public function __construct(Dispatcher $events)
    {
        $this->events = $events;
    }

    /**
     * Send the given notification.
     *
     * @param  mixed  $notifiable
     * @param  \Illuminate\Notifications\Notification  $notification
     * @return void
     */
    public function send($notifiable, Notification $notification)
    {
        $this->events->fire(new BroadcastNotificationCreated(
            $notifiable, $notification, $this->getData($notifiable, $notification)
        ));
    }

    /**
     * Get the data for the notification.
     *
     * @param  mixed  $notifiable
     * @param  \Illuminate\Notifications\Notification  $notification
     * @return array
     *
     * @throws \RuntimeException
     */
    protected function getData($notifiable, Notification $notification)
    {
        if (method_exists($notification, 'toArray')) {
            return $notification->toArray($notifiable);

        }

        throw new RuntimeException(
            'Notification is missing toArray method.'
        );
    }
}


1		<?php
2
3		namespace Illuminate\Notifications\Channels;
4
5		use RuntimeException;
6		use Illuminate\Notifications\Notification;
7		use Illuminate\Contracts\Events\Dispatcher;
8		use Illuminate\Notifications\Events\BroadcastNotificationCreated;
9
10		class BroadcastChannel
11		{
12		/**
13		* The event dispatcher.
14		*
15		* @var \Illuminate\Contracts\Events\Dispatcher
16		*/
17		protected $events;
18
19		/**
20		* Create a new database channel.
21		*
22		* @param \Illuminate\Contracts\Events\Dispatcher $events
23		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2016-08-17 17:41 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
24		*/
25	1	public function __construct(Dispatcher $events)
26		{
27	1	$this->events = $events;
28	1	}
29
30		/**
31		* Send the given notification.
32		*
33		* @param mixed $notifiable
34		* @param \Illuminate\Notifications\Notification $notification
35		* @return void
36		*/
37	1	public function send($notifiable, Notification $notification)
38		{
39	1	$this->events->fire(new BroadcastNotificationCreated(
40	1	$notifiable, $notification, $this->getData($notifiable, $notification)
41		));
42	1	}
43
44		/**
45		* Get the data for the notification.
46		*
47		* @param mixed $notifiable
48		* @param \Illuminate\Notifications\Notification $notification
49		* @return array
50		*
51		* @throws \RuntimeException
52		*/
53	1	protected function getData($notifiable, Notification $notification)
54		{
55	1	if (method_exists($notification, 'toArray')) {
56	1	return $notification->toArray($notifiable);
		0 ignored issues – show Bug introduced 2016-08-17 17:41 UTC by Report Bug Copy Issue Report The method `toArray()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
57		}
58
59		throw new RuntimeException(
60		'Notification is missing toArray method.'
61		);
62		}
63		}
64

laravel-notification-channels / backport

Push — master ( 88d547...129b2c )

BroadcastChannel::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like