ApnChannel::__construct() - Code Metrics - Inspection of "Attempt to unify credentials" - laravel-notification-channels/apn - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#36)

by Dwight

created 2018-02-09 06:13 UTC

ApnChannel::__construct() A

↳ Parent: ApnChannel

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
ccs	5
cts	5
cp	1
rs	9.4285
cc	1
eloc	4
nc	1
nop	3
crap	1

<?php

namespace NotificationChannels\Apn;

use Exception;
use Illuminate\Events\Dispatcher;
use ZendService\Apple\Apns\Message\Alert;
use Illuminate\Notifications\Notification;
use ZendService\Apple\Apns\Message as Packet;
use ZendService\Apple\Apns\Client\Message as Client;
use NotificationChannels\Apn\Exceptions\SendingFailed;
use Illuminate\Notifications\Events\NotificationFailed;
use ZendService\Apple\Apns\Response\Message as Response;

class ApnChannel
{
    use InteractsWithConnection;

    /**
     * The sandbox environment identifier.
     *
     * @var int
     */
    const SANDBOX = 0;

    /**
     * The production environment identifier.
     *
     * @var int
     */
    const PRODUCTION = 1;

    /** @var \ZendService\Apple\Apns\Client\Message */
    protected $client;

    /** @var \Illuminate\Events\Dispatcher */
    protected $events;

    /** @var \NotificationChannels\Apn\ApnCredentials */
    protected $credentials;

    /**
     * Create a new instance of the APN channel.
     *
     * @param  \ZendService\Apple\Apns\Client\Message  $client
     * @param  \Illuminate\Events\Dispatcher  $events
     * @param  \NotificationChannels\Apn\ApnCredentials  $credentials
     */
    public function __construct(Client $client, Dispatcher $events, ApnCredentials $credentials)
    {
        $this->client = $client;
        $this->events = $events;
        $this->credentials = $credentials;
    }

    /**
     * Send the notification to Apple Push Notification Service.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @throws \NotificationChannels\Apn\Exceptions\SendingFailed
     */
    public function send($notifiable, Notification $notification)
    {
        $tokens = (array) $notifiable->routeNotificationFor('apn');
        if (empty($tokens)) {
            return;
        }

        $message = $notification->toApn($notifiable);

        if (! $message) {
            return;
        }

        $this->openConnection();

        foreach ($tokens as $token) {
            try {
                $alert = new Alert();
                $alert->setTitle($message->title);
                $alert->setBody($message->body);

                $packet = new Packet();
                $packet->setToken($token);
                $packet->setBadge($message->badge);
                $packet->setSound($message->sound);
                $packet->setCategory($message->category);
                $packet->setContentAvailable($message->contentAvailable);
                $packet->setAlert($alert);
                $packet->setCustom($message->custom);

                $response = $this->client->send($packet);

                if ($response->getCode() !== Response::RESULT_OK) {
                    $this->events->fire(
                        new NotificationFailed($notifiable, $notification, $this, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                            'token' => $token,
                            'error' => $response->getCode(),
                        ])
                    );
                }
            } catch (Exception $e) {
                throw SendingFailed::create($e);
            }
        }

        $this->closeConnection();
    }
}


1		<?php
2
3		namespace NotificationChannels\Apn;
4
5		use Exception;
6		use Illuminate\Events\Dispatcher;
7		use ZendService\Apple\Apns\Message\Alert;
8		use Illuminate\Notifications\Notification;
9		use ZendService\Apple\Apns\Message as Packet;
10		use ZendService\Apple\Apns\Client\Message as Client;
11		use NotificationChannels\Apn\Exceptions\SendingFailed;
12		use Illuminate\Notifications\Events\NotificationFailed;
13		use ZendService\Apple\Apns\Response\Message as Response;
14
15		class ApnChannel
16		{
17		use InteractsWithConnection;
18
19		/**
20		* The sandbox environment identifier.
21		*
22		* @var int
23		*/
24		const SANDBOX = 0;
25
26		/**
27		* The production environment identifier.
28		*
29		* @var int
30		*/
31		const PRODUCTION = 1;
32
33		/** @var \ZendService\Apple\Apns\Client\Message */
34		protected $client;
35
36		/** @var \Illuminate\Events\Dispatcher */
37		protected $events;
38
39		/** @var \NotificationChannels\Apn\ApnCredentials */
40		protected $credentials;
41
42		/**
43		* Create a new instance of the APN channel.
44		*
45		* @param \ZendService\Apple\Apns\Client\Message $client
46		* @param \Illuminate\Events\Dispatcher $events
47		* @param \NotificationChannels\Apn\ApnCredentials $credentials
48		*/
49	2	public function __construct(Client $client, Dispatcher $events, ApnCredentials $credentials)
50		{
51	2	$this->client = $client;
52	2	$this->events = $events;
53	2	$this->credentials = $credentials;
54	2	}
55
56		/**
57		* Send the notification to Apple Push Notification Service.
58		*
59		* @param mixed $notifiable
60		* @param \Illuminate\Notifications\Notification $notification
61		*
62		* @throws \NotificationChannels\Apn\Exceptions\SendingFailed
63		*/
64	2	public function send($notifiable, Notification $notification)
65		{
66	2	$tokens = (array) $notifiable->routeNotificationFor('apn');
67	2	if (empty($tokens)) {
68		return;
69		}
70
71	2	$message = $notification->toApn($notifiable);
		0 ignored issues – show Bug introduced 2017-02-01 22:31 UTC by Report Bug Copy Issue Report The method `toApn()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
72	2	if (! $message) {
73		return;
74		}
75
76	2	$this->openConnection();
77
78	2	foreach ($tokens as $token) {
79		try {
80	2	$alert = new Alert();
81	2	$alert->setTitle($message->title);
82	2	$alert->setBody($message->body);
83
84	2	$packet = new Packet();
85	2	$packet->setToken($token);
86	2	$packet->setBadge($message->badge);
87	2	$packet->setSound($message->sound);
88	2	$packet->setCategory($message->category);
89	2	$packet->setContentAvailable($message->contentAvailable);
90	2	$packet->setAlert($alert);
91	2	$packet->setCustom($message->custom);
92
93	2	$response = $this->client->send($packet);
94
95	2	if ($response->getCode() !== Response::RESULT_OK) {
96	1	$this->events->fire(
97	1	new NotificationFailed($notifiable, $notification, $this, [
		0 ignored issues – show Documentation introduced 2016-09-24 12:53 UTC by Report Bug Copy Issue Report `$this` is of type `this<NotificationChannels\Apn\ApnChannel>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
98	1	'token' => $token,
99	2	'error' => $response->getCode(),
100		])
101		);
102		}
103		} catch (Exception $e) {
104	2	throw SendingFailed::create($e);
105		}
106		}
107
108	2	$this->closeConnection();
109	2	}
110		}
111

laravel-notification-channels / apn

GitHub Access Token became invalid

Pull Request — master (#36)

ApnChannel::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like