ApnChannel - Code Metrics - Inspection of "Merge pull request #42 from laravel-notification-c..." - laravel-notification-channels/apn - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 395778...35ff7e )

by Dwight

created 2018-02-17 22:28 UTC

ApnChannel A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	117
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

88.57%

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
wmc	9
c	5
b	0
f	0
lcom	1
cbo	6
dl	0
loc	117
ccs	31
cts	35
cp	0.8857
rs	10

4 Methods

Rating	Name	Size	Complexity
A	__construct()	11	1
A	send()	14	3
A	sendNotifications()	15	2
A	sendNotification()	17	3

<?php

namespace NotificationChannels\Apn;

use Exception;
use Illuminate\Events\Dispatcher;
use Illuminate\Notifications\Notification;
use ZendService\Apple\Apns\Client\Message as Client;
use NotificationChannels\Apn\Exceptions\SendingFailed;
use Illuminate\Notifications\Events\NotificationFailed;
use ZendService\Apple\Apns\Response\Message as Response;

class ApnChannel
{
    use InteractsWithConnection;

    /**
     * The sandbox environment identifier.
     *
     * @var int
     */
    const SANDBOX = 0;

    /**
     * The production environment identifier.
     *
     * @var int
     */
    const PRODUCTION = 1;

    /** @var \ZendService\Apple\Apns\Client\Message */
    protected $client;

    /** @var \Illuminate\Events\Dispatcher */
    protected $events;

    /** @var \NotificationChannels\Apn\ApnCredentials */
    protected $credentials;

    /**
     * Create a new instance of the APN channel.
     *
     * @param  \ZendService\Apple\Apns\Client\Message  $client
     * @param  \Illuminate\Events\Dispatcher  $events
     * @param  \NotificationChannels\Apn\ApnCredentials  $credentials
     */
    public function __construct(
        Client $client,
        Dispatcher $events,
        ApnAdapter $adapter,
        ApnCredentials $credentials
    ) {
        $this->client = $client;
        $this->events = $events;
        $this->adapter = $adapter;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->credentials = $credentials;
    }

    /**
     * Send the notification to Apple Push Notification Service.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     */
    public function send($notifiable, Notification $notification)
    {
        $tokens = (array) $notifiable->routeNotificationFor('apn');
        if (empty($tokens)) {
            return;
        }

        $message = $notification->toApn($notifiable);

        if (! $message) {
            return;
        }

        $this->sendNotifications($notifiable, $notification, $tokens, $message);
    }

    /**
     * Send the notification to each of the provided tokens.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     */
    protected function sendNotifications($notifiable, $notification, $tokens, $message)
    {
        foreach ($tokens as $token) {
            $this->openConnection();

            $this->sendNotification(
                $notifiable,
                $notification,
                $this->adapter->adapt($message, $token),
                $token
            );

            $this->closeConnection();
        }
    }

    /**
     * Sent the notification to the given token.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     * @param \ZendService\Apple\Apns\Message  $message
     * @param  string  $token
     * @return void
     * @throws \NotificationChannels\Apn\Exceptions\SendingFailed
     */
    protected function sendNotification($notifiable, $notification, $message, $token)
    {
        try {
            $response = $this->client->send($message);

            if ($response->getCode() !== Response::RESULT_OK) {
                $this->events->fire(
                    new NotificationFailed($notifiable, $notification, $this, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                        'token' => $token,
                        'error' => $response->getCode(),
                    ])
                );
            }
        } catch (Exception $e) {
            throw SendingFailed::create($e);
        }
    }
}


1		<?php
2
3		namespace NotificationChannels\Apn;
4
5		use Exception;
6		use Illuminate\Events\Dispatcher;
7		use Illuminate\Notifications\Notification;
8		use ZendService\Apple\Apns\Client\Message as Client;
9		use NotificationChannels\Apn\Exceptions\SendingFailed;
10		use Illuminate\Notifications\Events\NotificationFailed;
11		use ZendService\Apple\Apns\Response\Message as Response;
12
13		class ApnChannel
14		{
15		use InteractsWithConnection;
16
17		/**
18		* The sandbox environment identifier.
19		*
20		* @var int
21		*/
22		const SANDBOX = 0;
23
24		/**
25		* The production environment identifier.
26		*
27		* @var int
28		*/
29		const PRODUCTION = 1;
30
31		/** @var \ZendService\Apple\Apns\Client\Message */
32		protected $client;
33
34		/** @var \Illuminate\Events\Dispatcher */
35		protected $events;
36
37		/** @var \NotificationChannels\Apn\ApnCredentials */
38		protected $credentials;
39
40		/**
41		* Create a new instance of the APN channel.
42		*
43		* @param \ZendService\Apple\Apns\Client\Message $client
44		* @param \Illuminate\Events\Dispatcher $events
45		* @param \NotificationChannels\Apn\ApnCredentials $credentials
46		*/
47	2	public function __construct(
48		Client $client,
49		Dispatcher $events,
50		ApnAdapter $adapter,
51		ApnCredentials $credentials
52		) {
53	2	$this->client = $client;
54	2	$this->events = $events;
55	2	$this->adapter = $adapter;
		0 ignored issues – show Bug introduced 2018-02-17 03:31 UTC by Report Bug Copy Issue Report The property `adapter` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
56	2	$this->credentials = $credentials;
57	2	}
58
59		/**
60		* Send the notification to Apple Push Notification Service.
61		*
62		* @param mixed $notifiable
63		* @param \Illuminate\Notifications\Notification $notification
64		*/
65	2	public function send($notifiable, Notification $notification)
66		{
67	2	$tokens = (array) $notifiable->routeNotificationFor('apn');
68	2	if (empty($tokens)) {
69		return;
70		}
71
72	2	$message = $notification->toApn($notifiable);
		0 ignored issues – show Bug introduced 2017-02-01 22:31 UTC by Report Bug Copy Issue Report The method `toApn()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
73	2	if (! $message) {
74		return;
75		}
76
77	2	$this->sendNotifications($notifiable, $notification, $tokens, $message);
78	2	}
79
80		/**
81		* Send the notification to each of the provided tokens.
82		*
83		* @param mixed $notifiable
84		* @param \Illuminate\Notifications\Notification $notification
85		*/
86	2	protected function sendNotifications($notifiable, $notification, $tokens, $message)
87		{
88	2	foreach ($tokens as $token) {
89	2	$this->openConnection();
90
91	2	$this->sendNotification(
92	2	$notifiable,
93	2	$notification,
94	2	$this->adapter->adapt($message, $token),
95	2	$token
96		);
97
98	2	$this->closeConnection();
99		}
100	2	}
101
102		/**
103		* Sent the notification to the given token.
104		*
105		* @param mixed $notifiable
106		* @param \Illuminate\Notifications\Notification $notification
107		* @param \ZendService\Apple\Apns\Message $message
108		* @param string $token
109		* @return void
110		* @throws \NotificationChannels\Apn\Exceptions\SendingFailed
111		*/
112	2	protected function sendNotification($notifiable, $notification, $message, $token)
113		{
114		try {
115	2	$response = $this->client->send($message);
116
117	2	if ($response->getCode() !== Response::RESULT_OK) {
118	1	$this->events->fire(
119	1	new NotificationFailed($notifiable, $notification, $this, [
		0 ignored issues – show Documentation introduced 2016-09-24 12:53 UTC by Report Bug Copy Issue Report `$this` is of type `this<NotificationChannels\Apn\ApnChannel>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
120	1	'token' => $token,
121	2	'error' => $response->getCode(),
122		])
123		);
124		}
125		} catch (Exception $e) {
126		throw SendingFailed::create($e);
127		}
128	2	}
129		}
130

laravel-notification-channels / apn

GitHub Access Token became invalid

Push — master ( 395778...35ff7e )

ApnChannel A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like