ApnChannel::sendNotifications() - Code Metrics - Inspection of "Update return values" - laravel-notification-channels/apn - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4580b2...aafc3c )

by Dwight

created 2020-02-19 22:29 UTC

ApnChannel::sendNotifications() A

↳ Parent: ApnChannel

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	6
cts	6
cp	1
rs	9.8666
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	2

<?php

namespace NotificationChannels\Apn;

use Illuminate\Notifications\Notification;
use Pushok\Client;
use Pushok\Notification as PushNotification;

class ApnChannel
{
    /**
     * The sandbox environment identifier.
     *
     * @var int
     */
    const SANDBOX = 0;

    /**
     * The production environment identifier.
     *
     * @var int
     */
    const PRODUCTION = 1;

    /**
     * The APNS client.
     *
     * @var \Pushok\Client
     */
    protected $client;

    /**
     * Create a new channel instance.
     *
     * @param  \Pushok\Client  $client
     */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    /**
     * Send the notification to Apple Push Notification Service.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     * @return array|void
     */
    public function send($notifiable, Notification $notification)
    {
        $tokens = (array) $notifiable->routeNotificationFor('apn', $notification);

        if (empty($tokens)) {
            return;
        }

        $message = $notification->toApn($notifiable);


        $payload = (new ApnAdapter)->adapt($message);

        return $this->sendNotifications($tokens, $payload);
    }

    /**
     * Send the notification to each of the provided tokens.
     *
     * @param  array  $tokens
     * @param  \Pushok\Payload  $payload
     * @return array
     */
    protected function sendNotifications($tokens, $payload)
    {
        $notifications = [];

        foreach ($tokens as $token) {
            $notifications[] = new PushNotification($payload, $token);
        }

        $this->client->addNotifications($notifications);

        return $this->client->push();
    }
}


1		<?php
2
3		namespace NotificationChannels\Apn;
4
5		use Illuminate\Notifications\Notification;
6		use Pushok\Client;
7		use Pushok\Notification as PushNotification;
8
9		class ApnChannel
10		{
11		/**
12		* The sandbox environment identifier.
13		*
14		* @var int
15		*/
16		const SANDBOX = 0;
17
18		/**
19		* The production environment identifier.
20		*
21		* @var int
22		*/
23		const PRODUCTION = 1;
24
25		/**
26		* The APNS client.
27		*
28		* @var \Pushok\Client
29		*/
30		protected $client;
31
32		/**
33		* Create a new channel instance.
34		*
35		* @param \Pushok\Client $client
36		*/
37	1	public function __construct(Client $client)
38		{
39	1	$this->client = $client;
40	1	}
41
42		/**
43		* Send the notification to Apple Push Notification Service.
44		*
45		* @param mixed $notifiable
46		* @param \Illuminate\Notifications\Notification $notification
47		* @return array\|void
48		*/
49	1	public function send($notifiable, Notification $notification)
50		{
51	1	$tokens = (array) $notifiable->routeNotificationFor('apn', $notification);
52
53	1	if (empty($tokens)) {
54		return;
55		}
56
57	1	$message = $notification->toApn($notifiable);
		0 ignored issues – show Bug introduced 2017-02-01 22:31 UTC by Report Bug Copy Issue Report The method `toApn()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
58
59	1	$payload = (new ApnAdapter)->adapt($message);
60
61	1	return $this->sendNotifications($tokens, $payload);
62		}
63
64		/**
65		* Send the notification to each of the provided tokens.
66		*
67		* @param array $tokens
68		* @param \Pushok\Payload $payload
69		* @return array
70		*/
71	1	protected function sendNotifications($tokens, $payload)
72		{
73	1	$notifications = [];
74
75	1	foreach ($tokens as $token) {
76	1	$notifications[] = new PushNotification($payload, $token);
77		}
78
79	1	$this->client->addNotifications($notifications);
80
81	1	return $this->client->push();
82		}
83		}
84

laravel-notification-channels / apn

GitHub Access Token became invalid

Push — master ( 4580b2...aafc3c )

ApnChannel::sendNotifications() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like