FeedbackService::fetchFeedback() - Code Metrics - Inspection of "Automatically open connection" - laravel-notification-channels/apn - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#37)

by Dwight

created 2018-02-09 14:28 UTC

FeedbackService::fetchFeedback() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
ccs	5
cts	5
cp	1
rs	9.4285
cc	2
eloc	5
nc	2
nop	0
crap	2

<?php

namespace NotificationChannels\Apn;

use ZendService\Apple\Apns\Client\Feedback as Client;

class FeedbackService
{
    /**
     * The feedback client instance.
     *
     * @var \ZendService\Apple\Apns\Client\Feedback
     */
    protected $client;

    /**
     * Create feedback service instance.
     *
     * @param  \ZendService\Apple\Apns\Client\Feedback  $client
     */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    /**
     * Get feedback from the Apple Feedback Service about failed deliveries.
     *
     * @return array|ApnFeedback[]
     * @throws Exceptions\ConnectionFailed
     */
    public function get()
    {
        $feedback = [];

        /** @var FeedbackResponse $response */
        foreach ($this->client->feedback() as $response) {
            $feedback[] = new ApnFeedback($response->getToken(), $response->getTime());
        }

        return $feedback;
    }
}


1		<?php
2
3		namespace NotificationChannels\Apn;
4
5		use ZendService\Apple\Apns\Client\Feedback as Client;
6
7		class FeedbackService
8		{
9		/**
10		* The feedback client instance.
11		*
12		* @var \ZendService\Apple\Apns\Client\Feedback
13		*/
14		protected $client;
15
16		/**
17		* Create feedback service instance.
18		*
19		* @param \ZendService\Apple\Apns\Client\Feedback $client
20		*/
21	1	public function __construct(Client $client)
22		{
23	1	$this->client = $client;
24	1	}
25
26		/**
27		* Get feedback from the Apple Feedback Service about failed deliveries.
28		*
29		* @return array\|ApnFeedback[]
30		* @throws Exceptions\ConnectionFailed
31		*/
32	1	public function get()
33		{
34	1	$feedback = [];
35
36		/** @var FeedbackResponse $response */
37	1	foreach ($this->client->feedback() as $response) {
38	1	$feedback[] = new ApnFeedback($response->getToken(), $response->getTime());
39		}
40
41	1	return $feedback;
42		}
43		}
44

laravel-notification-channels / apn

GitHub Access Token became invalid

Pull Request — master (#37)

FeedbackService::fetchFeedback() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like