ApnCredentials::environment() - Code Metrics - Inspection of "Attempt to unify credentials" - laravel-notification-channels/apn - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#36)

by Dwight

created 2018-02-09 06:04 UTC

ApnCredentials::environment() A

↳ Parent: ApnCredentials

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace NotificationChannels\Apn;

use Illuminate\Contracts\Config\Repository;

class ApnCredentials
{
    /**
     * Create a new instance of the credentials.
     *
     * @param  \Illuminate\Contracts\Config\Repository
     */
    public function __construct(Repository $config)
    {
        $this->config = $config;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get the APN environment.
     *
     * @return string
     */
    public function environment()
    {
        return $this->config->get('broadcasting.connections.apn.environment');
    }

    /**
     * Get the APN certificate..
     *
     * @return string
     */
    public function certificate()
    {
        return $this->config->get('broadcasting.connections.apn.certificate');
    }

    /**
     * Get the APN pass phrase.
     *
     * @return string
     */
    public function passPhrase()
    {
        return $this->config->get('broadcasting.connections.apn.pass_phrase');
    }
}


1			<?php
2
3			namespace NotificationChannels\Apn;
4
5			use Illuminate\Contracts\Config\Repository;
6
7			class ApnCredentials
8			{
9			/**
10			* Create a new instance of the credentials.
11			*
12			* @param \Illuminate\Contracts\Config\Repository
13			*/
14			public function __construct(Repository $config)
15			{
16			$this->config = $config;
			0 ignored issues – show Bug introduced 2018-02-09 06:07 UTC by Report Bug Copy Issue Report The property `config` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17			}
18
19			/**
20			* Get the APN environment.
21			*
22			* @return string
23			*/
24			public function environment()
25			{
26			return $this->config->get('broadcasting.connections.apn.environment');
27			}
28
29			/**
30			* Get the APN certificate..
31			*
32			* @return string
33			*/
34			public function certificate()
35			{
36			return $this->config->get('broadcasting.connections.apn.certificate');
37			}
38
39			/**
40			* Get the APN pass phrase.
41			*
42			* @return string
43			*/
44			public function passPhrase()
45			{
46			return $this->config->get('broadcasting.connections.apn.pass_phrase');
47			}
48			}
49

laravel-notification-channels / apn

GitHub Access Token became invalid

Pull Request — master (#36)

ApnCredentials::environment() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like