ApnChannel::openConnection() - Code Metrics - Inspection of "Break APNS feedback out of the channel" - laravel-notification-channels/apn - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#35)

by Dwight

created 2018-02-09 05:23 UTC

ApnChannel::openConnection() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.2559

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	3
cts	5
cp	0.6
rs	9.4285
cc	2
eloc	5
nc	2
nop	0
crap	2.2559

<?php

namespace NotificationChannels\Apn;

use Exception;
use Illuminate\Events\Dispatcher;
use ZendService\Apple\Apns\Message\Alert;
use Illuminate\Notifications\Notification;
use ZendService\Apple\Apns\Message as Packet;
use ZendService\Apple\Apns\Client\Message as Client;
use NotificationChannels\Apn\Exceptions\SendingFailed;
use Illuminate\Notifications\Events\NotificationFailed;
use ZendService\Apple\Apns\Response\Message as Response;

class ApnChannel
{
    use InteractsWithConnection;

    const SANDBOX = 0;
    const PRODUCTION = 1;

    /** @var \ZendService\Apple\Apns\Client\Message */
    protected $client;

    /** @var \Illuminate\Events\Dispatcher */
    protected $events;

    /**
     * @param \ZendService\Apple\Apns\Client\Message $client
     * @param \Illuminate\Events\Dispatcher $events
     * @param string $environment
     * @param string $certificate
     * @param string|null $passPhrase
     */
    public function __construct(
        Client $client,
        Dispatcher $events,
        $environment,
        $certificate,
        $passPhrase = null
    ) {
        $this->client = $client;
        $this->events = $events;
        $this->environment = $environment;
        $this->certificate = $certificate;
        $this->passPhrase = $passPhrase;
    }

    /**
     * Send the notification to Apple Push Notification Service.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @throws \NotificationChannels\Apn\Exceptions\SendingFailed
     */
    public function send($notifiable, Notification $notification)
    {
        $tokens = (array) $notifiable->routeNotificationFor('apn');
        if (! $tokens) {

            return;
        }

        $message = $notification->toApn($notifiable);

        if (! $message) {
            return;
        }

        $this->openConnection();

        foreach ($tokens as $token) {
            try {
                $alert = new Alert();
                $alert->setTitle($message->title);
                $alert->setBody($message->body);

                $packet = new Packet();
                $packet->setToken($token);
                $packet->setBadge($message->badge);
                $packet->setSound($message->sound);
                $packet->setCategory($message->category);
                $packet->setContentAvailable($message->contentAvailable);
                $packet->setAlert($alert);
                $packet->setCustom($message->custom);

                $response = $this->client->send($packet);

                if ($response->getCode() !== Response::RESULT_OK) {
                    $this->events->fire(
                        new NotificationFailed($notifiable, $notification, $this, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                            'token' => $token,
                            'error' => $response->getCode(),
                        ])
                    );
                }
            } catch (Exception $e) {
                throw SendingFailed::create($e);
            }
        }

        $this->closeConnection();
    }
}


1		<?php
2
3		namespace NotificationChannels\Apn;
4
5		use Exception;
6		use Illuminate\Events\Dispatcher;
7		use ZendService\Apple\Apns\Message\Alert;
8		use Illuminate\Notifications\Notification;
9		use ZendService\Apple\Apns\Message as Packet;
10		use ZendService\Apple\Apns\Client\Message as Client;
11		use NotificationChannels\Apn\Exceptions\SendingFailed;
12		use Illuminate\Notifications\Events\NotificationFailed;
13		use ZendService\Apple\Apns\Response\Message as Response;
14
15		class ApnChannel
16		{
17		use InteractsWithConnection;
18
19		const SANDBOX = 0;
20		const PRODUCTION = 1;
21
22		/** @var \ZendService\Apple\Apns\Client\Message */
23		protected $client;
24
25		/** @var \Illuminate\Events\Dispatcher */
26		protected $events;
27
28		/**
29		* @param \ZendService\Apple\Apns\Client\Message $client
30		* @param \Illuminate\Events\Dispatcher $events
31		* @param string $environment
32		* @param string $certificate
33		* @param string\|null $passPhrase
34		*/
35	2	public function __construct(
36		Client $client,
37		Dispatcher $events,
38		$environment,
39		$certificate,
40		$passPhrase = null
41		) {
42	2	$this->client = $client;
43	2	$this->events = $events;
44	2	$this->environment = $environment;
45	2	$this->certificate = $certificate;
46	2	$this->passPhrase = $passPhrase;
47	2	}
48
49		/**
50		* Send the notification to Apple Push Notification Service.
51		*
52		* @param mixed $notifiable
53		* @param \Illuminate\Notifications\Notification $notification
54		*
55		* @throws \NotificationChannels\Apn\Exceptions\SendingFailed
56		*/
57	2	public function send($notifiable, Notification $notification)
58		{
59	2	$tokens = (array) $notifiable->routeNotificationFor('apn');
60	2	if (! $tokens) {
		0 ignored issues – show Bug Best Practice introduced 2016-09-24 12:53 UTC by Report Bug Copy Issue Report The expression `$tokens` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
61		return;
62		}
63
64	2	$message = $notification->toApn($notifiable);
		0 ignored issues – show Bug introduced 2017-02-01 22:31 UTC by Report Bug Copy Issue Report The method `toApn()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
65	2	if (! $message) {
66		return;
67		}
68
69	2	$this->openConnection();
70
71	2	foreach ($tokens as $token) {
72		try {
73	2	$alert = new Alert();
74	2	$alert->setTitle($message->title);
75	2	$alert->setBody($message->body);
76
77	2	$packet = new Packet();
78	2	$packet->setToken($token);
79	2	$packet->setBadge($message->badge);
80	2	$packet->setSound($message->sound);
81	2	$packet->setCategory($message->category);
82	2	$packet->setContentAvailable($message->contentAvailable);
83	2	$packet->setAlert($alert);
84	2	$packet->setCustom($message->custom);
85
86	2	$response = $this->client->send($packet);
87
88	2	if ($response->getCode() !== Response::RESULT_OK) {
89	1	$this->events->fire(
90	1	new NotificationFailed($notifiable, $notification, $this, [
		0 ignored issues – show Documentation introduced 2016-09-24 12:53 UTC by Report Bug Copy Issue Report `$this` is of type `this<NotificationChannels\Apn\ApnChannel>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
91	1	'token' => $token,
92	2	'error' => $response->getCode(),
93		])
94		);
95		}
96		} catch (Exception $e) {
97	2	throw SendingFailed::create($e);
98		}
99		}
100
101	2	$this->closeConnection();
102	2	}
103		}
104

laravel-notification-channels / apn

GitHub Access Token became invalid

Pull Request — master (#35)

ApnChannel::openConnection() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like