ApnChannel::getFeedback() - Code Metrics - Inspection of "Break APNS feedback out of the channel" - laravel-notification-channels/apn - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#35)

by Dwight

created 2018-02-09 05:12 UTC

ApnChannel::getFeedback() A

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3.072

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	21
ccs	8
cts	10
cp	0.8
rs	9.3142
cc	3
eloc	11
nc	3
nop	0
crap	3.072

<?php

namespace NotificationChannels\Apn;

use Illuminate\Events\Dispatcher;
use ZendService\Apple\Apns\Message\Alert;
use Illuminate\Notifications\Notification;
use ZendService\Apple\Apns\Message as Packet;
use ZendService\Apple\Apns\Client\Message as Client;
use NotificationChannels\Apn\Exceptions\SendingFailed;
use Illuminate\Notifications\Events\NotificationFailed;
use ZendService\Apple\Apns\Response\Message as Response;

class ApnChannel
{
    use InteractsWithConnection;

    const SANDBOX = 0;
    const PRODUCTION = 1;

    /** @var \ZendService\Apple\Apns\Client\Message */
    protected $client;

    /** @var \Illuminate\Events\Dispatcher */
    protected $events;

    /**
     * @param \ZendService\Apple\Apns\Client\Message $client
     * @param \Illuminate\Events\Dispatcher $events
     * @param string $environment
     * @param string $certificate
     * @param string|null $passPhrase
     */
    public function __construct(
        Client $client,
        Dispatcher $events,
        $environment,
        $certificate,
        $passPhrase = null
    ) {
        $this->client = $client;
        $this->events = $events;
        $this->environment = $environment;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->certificate = $certificate;
        $this->passPhrase = $passPhrase;
    }

    /**
     * Send the notification to Apple Push Notification Service.
     *
     * @param mixed $notifiable
     * @param \Illuminate\Notifications\Notification $notification
     *
     * @throws \NotificationChannels\Apn\Exceptions\SendingFailed
     */
    public function send($notifiable, Notification $notification)
    {
        $tokens = (array) $notifiable->routeNotificationFor('apn');
        if (! $tokens) {

            return;
        }

        $message = $notification->toApn($notifiable);

        if (! $message) {
            return;
        }

        $this->openConnection();

        foreach ($tokens as $token) {
            try {
                $alert = new Alert();
                $alert->setTitle($message->title);
                $alert->setBody($message->body);

                $packet = new Packet();
                $packet->setToken($token);
                $packet->setBadge($message->badge);
                $packet->setSound($message->sound);
                $packet->setCategory($message->category);
                $packet->setContentAvailable($message->contentAvailable);
                $packet->setAlert($alert);
                $packet->setCustom($message->custom);

                $response = $this->client->send($packet);

                if ($response->getCode() !== Response::RESULT_OK) {
                    $this->events->fire(
                        new NotificationFailed($notifiable, $notification, $this, [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                            'token' => $token,
                            'error' => $response->getCode(),
                        ])
                    );
                }
            } catch (Exception $e) {

                throw SendingFailed::create($e);
            }
        }

        $this->closeConnection();
    }
}


1		<?php
2
3		namespace NotificationChannels\Apn;
4
5		use Illuminate\Events\Dispatcher;
6		use ZendService\Apple\Apns\Message\Alert;
7		use Illuminate\Notifications\Notification;
8		use ZendService\Apple\Apns\Message as Packet;
9		use ZendService\Apple\Apns\Client\Message as Client;
10		use NotificationChannels\Apn\Exceptions\SendingFailed;
11		use Illuminate\Notifications\Events\NotificationFailed;
12		use ZendService\Apple\Apns\Response\Message as Response;
13
14		class ApnChannel
15		{
16		use InteractsWithConnection;
17
18		const SANDBOX = 0;
19		const PRODUCTION = 1;
20
21		/** @var \ZendService\Apple\Apns\Client\Message */
22		protected $client;
23
24		/** @var \Illuminate\Events\Dispatcher */
25		protected $events;
26
27		/**
28		* @param \ZendService\Apple\Apns\Client\Message $client
29		* @param \Illuminate\Events\Dispatcher $events
30		* @param string $environment
31		* @param string $certificate
32		* @param string\|null $passPhrase
33		*/
34	2	public function __construct(
35		Client $client,
36		Dispatcher $events,
37		$environment,
38		$certificate,
39		$passPhrase = null
40		) {
41	2	$this->client = $client;
42	2	$this->events = $events;
43	2	$this->environment = $environment;
		0 ignored issues – show Documentation Bug introduced 2018-02-09 05:06 UTC by Report Bug Copy Issue Report The property `$environment` was declared of type `integer`, but `$environment` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
44	2	$this->certificate = $certificate;
45	2	$this->passPhrase = $passPhrase;
46	2	}
47
48		/**
49		* Send the notification to Apple Push Notification Service.
50		*
51		* @param mixed $notifiable
52		* @param \Illuminate\Notifications\Notification $notification
53		*
54		* @throws \NotificationChannels\Apn\Exceptions\SendingFailed
55		*/
56	2	public function send($notifiable, Notification $notification)
57		{
58	2	$tokens = (array) $notifiable->routeNotificationFor('apn');
59	2	if (! $tokens) {
		0 ignored issues – show Bug Best Practice introduced 2016-09-24 12:53 UTC by Report Bug Copy Issue Report The expression `$tokens` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
60		return;
61		}
62
63	2	$message = $notification->toApn($notifiable);
		0 ignored issues – show Bug introduced 2017-02-01 22:31 UTC by Report Bug Copy Issue Report The method `toApn()` does not seem to exist on `object<Illuminate\Notifications\Notification>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
64	2	if (! $message) {
65		return;
66		}
67
68	2	$this->openConnection();
69
70	2	foreach ($tokens as $token) {
71		try {
72	2	$alert = new Alert();
73	2	$alert->setTitle($message->title);
74	2	$alert->setBody($message->body);
75
76	2	$packet = new Packet();
77	2	$packet->setToken($token);
78	2	$packet->setBadge($message->badge);
79	2	$packet->setSound($message->sound);
80	2	$packet->setCategory($message->category);
81	2	$packet->setContentAvailable($message->contentAvailable);
82	2	$packet->setAlert($alert);
83	2	$packet->setCustom($message->custom);
84
85	2	$response = $this->client->send($packet);
86
87	2	if ($response->getCode() !== Response::RESULT_OK) {
88	1	$this->events->fire(
89	1	new NotificationFailed($notifiable, $notification, $this, [
		0 ignored issues – show Documentation introduced 2016-09-24 12:53 UTC by Report Bug Copy Issue Report `$this` is of type `this<NotificationChannels\Apn\ApnChannel>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
90	1	'token' => $token,
91	2	'error' => $response->getCode(),
92		])
93		);
94		}
95		} catch (Exception $e) {
		0 ignored issues – show Bug introduced 2018-02-09 05:12 UTC by Report Bug Copy Issue Report The class `NotificationChannels\Apn\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
96	2	throw SendingFailed::create($e);
97		}
98		}
99
100	2	$this->closeConnection();
101	2	}
102		}
103

laravel-notification-channels / apn

GitHub Access Token became invalid

Pull Request — master (#35)

ApnChannel::getFeedback() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like