FeedbackService::__construct() - Code Metrics - Inspection of "Break APNS feedback out of the channel" - laravel-notification-channels/apn - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#35)

by Dwight

created 2018-02-09 04:53 UTC

FeedbackService::__construct() A

↳ Parent: FeedbackService

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	7
ccs	6
cts	6
cp	1
rs	9.4285
cc	1
eloc	5
nc	1
nop	4
crap	1

<?php

namespace NotificationChannels\Apn;

use ZendService\Apple\Apns\Client\Feedback as Client;
use NotificationChannels\Apn\Exception\ConnectionFailed;

class FeedbackService
{
    /**
     * The feedback client instance.
     *
     * @var \ZendService\Apple\Apns\Client\Feedback
     */
    protected $client;

    /**
     * Create feedback service instance.
     *
     * @param  \ZendService\Apple\Apns\Client\Feedback  $client
     * @param  string  $environment
     * @param  string  $certificate
     * @param  string|null  $passPhrase
     * @return void

     */
    public function __construct(Client $client, $environment, $certificate, $passPhrase = null)
    {
        $this->client = $client;
        $this->environment = $environment;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->certificate = $certificate;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->passPhrase = $passPhrase;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get feedback from the Apple Feedback Service about failed deliveries.
     *
     * @return array|ApnFeedback[]
     * @throws Exceptions\ConnectionFailed
     */
    public function get()
    {
        $this->openConnection();

        $feedback = $this->fetchFeedback();

        $this->client->close();

        return $feedback;
    }

    /**
     * Open the connection to the feedback service.
     *
     * @return void
     * @throws \NotificationChannels\Apn\Exception\ConnectionFailed
     */
    protected function openConnection()
    {
        try {
            $this->client->open($this->environment, $this->certificate, $this->passPhrase);
        } catch (Exception $exception) {

            throw ConnectionFailed::create($exception);
        }
    }

    /**
     * Fetch the feedback from APNS and collect our feedback object.
     *
     * @return array
     */
    protected function fetchFeedback()
    {
        $feedback = [];

        /** @var FeedbackResponse $response */
        foreach ($this->client->feedback() as $response) {
            $feedback[] = new ApnFeedback($response->getToken(), $response->getTime());
        }

        return $feedback;
    }
}


1		<?php
2
3		namespace NotificationChannels\Apn;
4
5		use ZendService\Apple\Apns\Client\Feedback as Client;
6		use NotificationChannels\Apn\Exception\ConnectionFailed;
7
8		class FeedbackService
9		{
10		/**
11		* The feedback client instance.
12		*
13		* @var \ZendService\Apple\Apns\Client\Feedback
14		*/
15		protected $client;
16
17		/**
18		* Create feedback service instance.
19		*
20		* @param \ZendService\Apple\Apns\Client\Feedback $client
21		* @param string $environment
22		* @param string $certificate
23		* @param string\|null $passPhrase
24		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2018-02-09 04:54 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
25		*/
26	1	public function __construct(Client $client, $environment, $certificate, $passPhrase = null)
27		{
28	1	$this->client = $client;
29	1	$this->environment = $environment;
		0 ignored issues – show Bug introduced 2018-02-09 04:54 UTC by Report Bug Copy Issue Report The property `environment` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30	1	$this->certificate = $certificate;
		0 ignored issues – show Bug introduced 2018-02-09 04:54 UTC by Report Bug Copy Issue Report The property `certificate` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31	1	$this->passPhrase = $passPhrase;
		0 ignored issues – show Bug introduced 2018-02-09 04:54 UTC by Report Bug Copy Issue Report The property `passPhrase` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
32	1	}
33
34		/**
35		* Get feedback from the Apple Feedback Service about failed deliveries.
36		*
37		* @return array\|ApnFeedback[]
38		* @throws Exceptions\ConnectionFailed
39		*/
40	1	public function get()
41		{
42	1	$this->openConnection();
43
44	1	$feedback = $this->fetchFeedback();
45
46	1	$this->client->close();
47
48	1	return $feedback;
49		}
50
51		/**
52		* Open the connection to the feedback service.
53		*
54		* @return void
55		* @throws \NotificationChannels\Apn\Exception\ConnectionFailed
56		*/
57	1	protected function openConnection()
58		{
59		try {
60	1	$this->client->open($this->environment, $this->certificate, $this->passPhrase);
61		} catch (Exception $exception) {
		0 ignored issues – show Bug introduced 2018-02-09 04:54 UTC by Report Bug Copy Issue Report The class `NotificationChannels\Apn\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
62		throw ConnectionFailed::create($exception);
63		}
64	1	}
65
66		/**
67		* Fetch the feedback from APNS and collect our feedback object.
68		*
69		* @return array
70		*/
71	1	protected function fetchFeedback()
72		{
73	1	$feedback = [];
74
75		/** @var FeedbackResponse $response */
76	1	foreach ($this->client->feedback() as $response) {
77	1	$feedback[] = new ApnFeedback($response->getToken(), $response->getTime());
78		}
79
80	1	return $feedback;
81		}
82		}
83

laravel-notification-channels / apn

GitHub Access Token became invalid

Pull Request — master (#35)

FeedbackService::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like