InteractsWithConnection::openConnection() - Code Metrics - Inspection of "per message credentials" - laravel-notification-channels/apn - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#47)

unknown

created 2018-03-29 16:54 UTC

InteractsWithConnection::openConnection() A

↳ Parent: InteractsWithConnection

Complexity

Conditions	3
Paths	4

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
c	3
b	1
f	1
dl	0
loc	10
ccs	0
cts	9
cp	0
rs	9.4285
cc	3
eloc	6
nc	4
nop	1
crap	12

<?php

namespace NotificationChannels\Apn;

use Exception;
use NotificationChannels\Apn\Exceptions\ConnectionFailed;

trait InteractsWithConnection
{
    /**
     * The connection credentials.
     *
     * @var \NotificationChannels\Apn\ApnCredentials
     */
    protected $credentials;

    /**
     * Open the connection to the feedback service.
     *
     * @param \NotificationChannels\Apn\ApnCredentials $credentials
     *
     * @return void
     * @throws \NotificationChannels\Apn\Exception\ConnectionFailed
     */
    protected function openConnection(ApnCredentials $credentials = null)
    {
        try {
            $credentials = $credentials ?: $this->credentials;

            $this->client->open($credentials->environment, $credentials->certificate, $credentials->passPhrase);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        } catch (Exception $exception) {
            throw ConnectionFailed::create($exception);
        }
    }

    /**
     * Close the connection.
     *
     * @return void
     */
    protected function closeConnection()
    {
        $this->client->close();
    }
}


1			<?php
2
3			namespace NotificationChannels\Apn;
4
5			use Exception;
6			use NotificationChannels\Apn\Exceptions\ConnectionFailed;
7
8			trait InteractsWithConnection
9			{
10			/**
11			* The connection credentials.
12			*
13			* @var \NotificationChannels\Apn\ApnCredentials
14			*/
15			protected $credentials;
16
17			/**
18			* Open the connection to the feedback service.
19			*
20			* @param \NotificationChannels\Apn\ApnCredentials $credentials
21			*
22			* @return void
23			* @throws \NotificationChannels\Apn\Exception\ConnectionFailed
24			*/
25			protected function openConnection(ApnCredentials $credentials = null)
26			{
27			try {
28			$credentials = $credentials ?: $this->credentials;
29
30			$this->client->open($credentials->environment, $credentials->certificate, $credentials->passPhrase);
			0 ignored issues – show Bug introduced 2018-03-29 16:52 UTC by Report Bug Copy Issue Report The property `client` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31			} catch (Exception $exception) {
32			throw ConnectionFailed::create($exception);
33			}
34			}
35
36			/**
37			* Close the connection.
38			*
39			* @return void
40			*/
41			protected function closeConnection()
42			{
43			$this->client->close();
44			}
45			}
46

laravel-notification-channels / apn

GitHub Access Token became invalid

Pull Request — master (#47)

InteractsWithConnection::openConnection() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like