laravel-notification-channels / 46elks

src/FortySixElksSMS.php

<?php

namespace NotificationChannels\FortySixElks;

use NotificationChannels\FortySixElks\Exceptions\CouldNotSendNotification;

class FortySixElksSMS extends FortySixElksMedia implements FortySixElksMediaInterface
{
    const ENDPOINT = 'https://api.46elks.com/a1/SMS';

    protected array $form_params;

    /**
     * FortySixElksSMS constructor.
     */
    public function __construct()
    {
        $this->form_params = [];

        return parent::__construct();

Are you sure the usage of parent::__construct() targeting NotificationChannels\FortySixElks\FortySixElksMedia::__construct() seems to always return null.

    }

    /**
     * @return $this
     */
    public function send()
    {
        try {
            $response = $this->client->request('POST', self::ENDPOINT, [

The assignment to $response is dead and can be removed.

                'form_params' => array_merge(
                    $this->form_params,
                    [
                        'from'    => $this->from,
                        'to'      => $this->phone_number,
                        'message' => $this->getContent(),
                    ]
                ),
            ]);
        } catch (\GuzzleHttp\Exception\BadResponseException $e) {
            $response = $e->getResponse();

            throw CouldNotSendNotification::serviceRespondedWithAnError(
                $response->getBody()->getContents(),
                $response->getStatusCode()
            );
        }

        return $this;
    }

    /**
     * @return array
     */
    public function prepareParams(string $key, mixed $value): FortySixElksSMS
    {
        $this->form_params[$key] = $value;

        return $this;

The expression return $this returns the type NotificationChannels\FortySixElks\FortySixElksSMS which is incompatible with the documented return type array.

    }

    /**
     * @return void
     */
    public function flash(string $value = 'yes'): FortySixElksSMS
    {
        self::prepareParams(key: 'flash', value: $value);

The method NotificationChannels\FortySixElks\FortySixElksSMS::prepareParams() is not static, but was called statically.

        return $this;

The expression return $this returns the type NotificationChannels\FortySixElks\FortySixElksSMS which is incompatible with the documented return type void.

    }

    /**
     * @param string $value
     *
     * @return FortySixElksSMS
     */
    public function dry(string $value = 'yes'): FortySixElksSMS
    {
        self::prepareParams(key: 'dryrun', value: $value);

The method NotificationChannels\FortySixElks\FortySixElksSMS::prepareParams() is not static, but was called statically.

        return $this;
    }

    /**
     * @param string $url
     *
     * @return FortySixElksSMS
     */
    public function whenDelivered(string $url): FortySixElksSMS
    {
        self::prepareParams(key: 'whendelivered', value: $url);

The method NotificationChannels\FortySixElks\FortySixElksSMS::prepareParams() is not static, but was called statically.

        return $this;
    }

    /**
     * @return FortySixElksSMS
     */
    public function dontLog(): FortySixElksSMS
    {
        self::prepareParams(key: 'dontlog', value: 'message');

The method NotificationChannels\FortySixElks\FortySixElksSMS::prepareParams() is not static, but was called statically.

        return $this;
    }
}