laravel-liberu / genealogy

app/Upgrades/DumpActivityLog.php

<?php

namespace App\Upgrades;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Schema;
use LaravelEnso\Menus\Models\Menu;
use LaravelEnso\Permissions\Models\Permission;
use LaravelEnso\Upgrade\Contracts\MigratesData;
use LaravelEnso\Upgrade\Contracts\MigratesPostDataMigration;

class DumpActivityLog implements MigratesData, MigratesPostDataMigration
{
    public function isMigrated(): bool
    {
        return $this->menu()->doesntExist();

The expression return $this->menu()->doesntExist() could return the type Illuminate\Database\Eloquent\Builder which is incompatible with the type-hinted return boolean. Consider adding an additional type-check to rule them out.

    }

    public function migrateData(): void
    {
        DB::table('migrations')->whereIn('migration', [
            '2018_08_09_100000_create_activity_logs_table',
            '2018_08_09_101000_create_structure_for_activity_logs',
        ])->delete();

        $this->menu()->delete();

        Permission::whereName('core.activityLogs.index')->delete();
    }

    public function migratePostDataMigration(): void
    {
        Schema::dropIfExists('activity_logs');
    }

    private function menu(): Builder
    {
        return Menu::whereName('Activity Log');

The expression return LaravelEnso\Menus\Models\Menu::whereName('Activity Log') could return the type Illuminate\Database\Eloquent\PendingHasThroughRelationship which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

    }
}