laravel-liberu / genealogy

app/Traits/CreatedBy.php

<?php

namespace App\Traits;

use Illuminate\Database\Eloquent\Relations\Relation;
use Illuminate\Support\Facades\Config;

trait CreatedBy
{
    public static function bootCreatedBy()
    {
        self::creating(fn ($model) => $model->setCreatedBy());
    }

    public function createdBy(): Relation
    {
        $userModel = Config::get('auth.providers.users.model');

        return $this->belongsTo($userModel, 'created_by');

It seems like belongsTo() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public static function bootUpdatedBy()
    {
        self::creating(fn ($model) => $model->setUpdatedBy());
    }

    public function UpdatedBy(): Relation
    {
        $userModel = Config::get('auth.providers.users.model');

        return $this->belongsTo($userModel, 'updated_by');
    }

    private function setCreatedBy($value = 1)

The parameter $value is not used and could be removed.

    {
//        if($value==''){
//            if (Auth::check()) {
//                $this->created_by = Auth::id();
//            }
//        }else{
        $this->created_by = null;

The property created_by does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

//        }
    }

    private function setUpdatedBy($value = 1)

The parameter $value is not used and could be removed.

    {
//        if($value==''){
//            if (Auth::check()) {
//                $this->updated_by = Auth::id();
//            }
//        }else{
        $this->updated_by = null;

The property updated_by does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

//        }
    }
}